linux-kernel - Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeA7dVBmm1yuf6F9@hovoldconsulting.com>
Date: Thu, 29 Feb 2024 09:08:21 +0100
From: Johan Hovold <johan@...nel.org>
To: Vamshi Gajjela <vamshigajjela@...gle.com>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>,
	Stephen Boyd <sboyd@...nel.org>,
	Johan Hovold <johan+linaro@...nel.org>,
	Caleb Connolly <caleb.connolly@...aro.org>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] spmi: hisi-spmi-controller: Do not override device
 identifier

On Thu, Feb 29, 2024 at 12:21:16AM +0530, Vamshi Gajjela wrote:
> 'nr' member of struct spmi_controller, which serves as an identifier
> for the controller/bus. This value is a dynamic ID assigned in
> spmi_controller_alloc, and overriding it from the driver results in an
> ida_free error "ida_free called for id=xx which is not allocated".
> 
> Signed-off-by: Vamshi Gajjela <vamshigajjela@...gle.com>
> Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driver")
> Cc: stable@...r.kernel.org
> ---

This is v2, which should be indicated in the patch subject and with a
short changelog here (e.g. mentioning the split and rebase on 6.8-rc).

Johan