linux-kernel - Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic 7 segment LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXJT5THun7XG8ig746Bh+paAP5uSMg33aa=Csui4Dkb4g@mail.gmail.com>
Date: Thu, 29 Feb 2024 10:24:33 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Chris Packham <Chris.Packham@...iedtelesis.co.nz>
Cc: Rob Herring <robh@...nel.org>, "andy@...nel.org" <andy@...nel.org>, 
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>, 
	"conor+dt@...nel.org" <conor+dt@...nel.org>, "andrew@...n.ch" <andrew@...n.ch>, 
	"gregory.clement@...tlin.com" <gregory.clement@...tlin.com>, 
	"sebastian.hesselbarth@...il.com" <sebastian.hesselbarth@...il.com>, "ojeda@...nel.org" <ojeda@...nel.org>, 
	"tzimmermann@...e.de" <tzimmermann@...e.de>, "javierm@...hat.com" <javierm@...hat.com>, 
	"robin@...tonic.nl" <robin@...tonic.nl>, "lee@...nel.org" <lee@...nel.org>, "pavel@....cz" <pavel@....cz>, 
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, 
	"linux-leds@...r.kernel.org" <linux-leds@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, 
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v2 2/4] dt-bindings: auxdisplay: Add bindings for generic
 7 segment LED

Hi Chris,

On Wed, Feb 28, 2024 at 9:02 PM Chris Packham
<Chris.Packham@...iedtelesis.co.nz> wrote:
> On 29/02/24 03:04, Rob Herring wrote:
> > On Wed, Feb 28, 2024 at 10:22:42AM +1300, Chris Packham wrote:
> >> +  segment-gpios:
> >> +    description:
> >> +      An array of GPIOs one per segment.
> >> +    minItems: 7
> > How does one know which GPIO is which segment?
>
> I've expanded the description in v3.
>
> + An array of GPIOs one per segment. The first GPIO corresponds to the A
> + segment the last GPIO corresponds to the G segment.
>
> Do you think that's sufficient or do I need to add more? In the driver
> itself I've put a little ascii art diagram of the segments.

Given users are reading the bindings rather than the driver source,
I would move the diagram to the bindings.

Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds