linux-kernel - Re: [PATCH] drm: xlnx: dp: Reset DisplayPort IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ccd159ea-483b-4f00-a532-fcafc09e8f98@ideasonboard.com>
Date: Thu, 29 Feb 2024 11:48:24 +0200
From: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc: Rohit Visavalia <rohit.visavalia@....com>,
 maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
 airlied@...il.com, daniel@...ll.ch, michal.simek@....com,
 dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm: xlnx: dp: Reset DisplayPort IP

On 29/02/2024 11:05, Laurent Pinchart wrote:
> Tomi, could you push this through drm-misc ?
> 
> On Wed, Feb 28, 2024 at 06:22:25PM +0200, Laurent Pinchart wrote:
>> Hello Rohit,
>>
>> Thank you for the patch.
>>
>> On Fri, Feb 16, 2024 at 04:40:43AM -0800, Rohit Visavalia wrote:
>>> Assert DisplayPort reset signal before deasserting,
>>> it is to clear out any registers programmed before booting kernel.
>>>
>>> Signed-off-by: Rohit Visavalia <rohit.visavalia@....com>
>>> ---
>>>   drivers/gpu/drm/xlnx/zynqmp_dp.c | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
>>> index 1846c4971fd8..5a40aa1d4283 100644
>>> --- a/drivers/gpu/drm/xlnx/zynqmp_dp.c
>>> +++ b/drivers/gpu/drm/xlnx/zynqmp_dp.c
>>> @@ -1714,6 +1714,10 @@ int zynqmp_dp_probe(struct zynqmp_dpsub *dpsub)
>>>   		goto err_free;
>>>   	}
>>>   
>>> +	ret = zynqmp_dp_reset(dp, true);
>>> +	if (ret < 0)
>>> +		return ret;
>>> +
>>
>> This looks fine to me, so
>>
>> Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
>>

Thanks, tested and pushed to drm-misc-next.

  Tomi