linux-kernel - Re: [PATCH v3] USB:UAS:return ENODEV when submit urbs fail with device not attached

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a48c332-acbe-4677-b189-9dda01151d18@suse.com>
Date: Thu, 29 Feb 2024 12:52:18 +0100
From: Oliver Neukum <oneukum@...e.com>
To: Weitao Wang <WeitaoWang-oc@...oxin.com>, oneukum@...e.com,
 stern@...land.harvard.edu, gregkh@...uxfoundation.org,
 linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-scsi@...r.kernel.org, usb-storage@...ts.one-eyed-alien.net
Cc: WeitaoWang@...oxin.com, stable@...r.kernel.org
Subject: Re: [PATCH v3] USB:UAS:return ENODEV when submit urbs fail with
 device not attached



On 29.02.24 20:33, Weitao Wang wrote:
> In the scenario of entering hibernation with udisk in the system, if the
> udisk was gone or resume fail in the thaw phase of hibernation. Its state
> will be set to NOTATTACHED. At this point, usb_hub_wq was already freezed
> and can't not handle disconnect event. Next, in the poweroff phase of
> hibernation, SYNCHRONIZE_CACHE SCSI command will be sent to this udisk
> when poweroff this scsi device, which will cause uas_submit_urbs to be
> called to submit URB for sense/data/cmd pipe. However, these URBs will
> submit fail as device was set to NOTATTACHED state. Then, uas_submit_urbs
> will return a value SCSI_MLQUEUE_DEVICE_BUSY to the caller. That will lead
> the SCSI layer go into an ugly loop and system fail to go into hibernation.
> 
> On the other hand, when we specially check for -ENODEV in function
> uas_queuecommand_lck, returning DID_ERROR to SCSI layer will cause device
> poweroff fail and system shutdown instead of entering hibernation.
> 
> To fix this issue, let uas_submit_urbs to return original generic error
> when submitting URB failed. At the same time, we need to translate -ENODEV
> to DID_NOT_CONNECT for the SCSI layer.
> 
> Suggested-by: Oliver Neukum<oneukum@...e.com>
> Cc:stable@...r.kernel.org
> Signed-off-by: Weitao Wang<WeitaoWang-oc@...oxin.com>
Acked-by: Oliver Neukum <oneukum@...e.com>