linux-kernel - RE: [PATCH net-next v2 2/3] vhost_net: Call peek

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 29 Feb 2024 13:17:33 +0000
From: wangyunjian <wangyunjian@...wei.com>
To: Paolo Abeni <pabeni@...hat.com>, "mst@...hat.com" <mst@...hat.com>,
	"willemdebruijn.kernel@...il.com" <willemdebruijn.kernel@...il.com>,
	"jasowang@...hat.com" <jasowang@...hat.com>, "kuba@...nel.org"
	<kuba@...nel.org>, "bjorn@...nel.org" <bjorn@...nel.org>,
	"magnus.karlsson@...el.com" <magnus.karlsson@...el.com>,
	"maciej.fijalkowski@...el.com" <maciej.fijalkowski@...el.com>,
	"jonathan.lemon@...il.com" <jonathan.lemon@...il.com>, "davem@...emloft.net"
	<davem@...emloft.net>
CC: "bpf@...r.kernel.org" <bpf@...r.kernel.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>,
	"virtualization@...ts.linux.dev" <virtualization@...ts.linux.dev>, xudingke
	<xudingke@...wei.com>, "liwei (DT)" <liwei395@...wei.com>
Subject: RE: [PATCH net-next v2 2/3] vhost_net: Call peek_len when using xdp



> -----Original Message-----
> From: Paolo Abeni [mailto:pabeni@...hat.com]
> Sent: Thursday, February 29, 2024 6:49 PM
> To: wangyunjian <wangyunjian@...wei.com>; mst@...hat.com;
> willemdebruijn.kernel@...il.com; jasowang@...hat.com; kuba@...nel.org;
> bjorn@...nel.org; magnus.karlsson@...el.com; maciej.fijalkowski@...el.com;
> jonathan.lemon@...il.com; davem@...emloft.net
> Cc: bpf@...r.kernel.org; netdev@...r.kernel.org;
> linux-kernel@...r.kernel.org; kvm@...r.kernel.org;
> virtualization@...ts.linux.dev; xudingke <xudingke@...wei.com>; liwei (DT)
> <liwei395@...wei.com>
> Subject: Re: [PATCH net-next v2 2/3] vhost_net: Call peek_len when using xdp
> 
> On Wed, 2024-02-28 at 19:05 +0800, Yunjian Wang wrote:
> > If TUN supports AF_XDP TX zero-copy, the XDP program will enqueue
> > packets to the XDP ring and wake up the vhost worker. This requires
> > the vhost worker to call peek_len(), which can be used to consume XDP
> > descriptors.
> >
> > Signed-off-by: Yunjian Wang <wangyunjian@...wei.com>
> > ---
> >  drivers/vhost/net.c | 17 ++++++++++++-----
> >  1 file changed, 12 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/vhost/net.c b/drivers/vhost/net.c index
> > f2ed7167c848..077e74421558 100644
> > --- a/drivers/vhost/net.c
> > +++ b/drivers/vhost/net.c
> > @@ -207,6 +207,11 @@ static int vhost_net_buf_peek_len(void *ptr)
> >  	return __skb_array_len_with_tag(ptr);  }
> >
> > +static bool vhost_sock_xdp(struct socket *sock) {
> > +	return sock_flag(sock->sk, SOCK_XDP); }
> > +
> >  static int vhost_net_buf_peek(struct vhost_net_virtqueue *nvq)  {
> >  	struct vhost_net_buf *rxq = &nvq->rxq; @@ -214,6 +219,13 @@ static
> > int vhost_net_buf_peek(struct vhost_net_virtqueue *nvq)
> >  	if (!vhost_net_buf_is_empty(rxq))
> >  		goto out;
> >
> > +	if (ptr_ring_empty(nvq->rx_ring)) {
> > +		struct socket *sock = vhost_vq_get_backend(&nvq->vq);
> > +		/* Call peek_len to consume XSK descriptors, when using xdp */
> > +		if (vhost_sock_xdp(sock) && sock->ops->peek_len)
> > +			sock->ops->peek_len(sock);
> 
> This really looks like a socket API misuse. Why can't you use ptr-ring primitives
> to consume XSK descriptors? peek_len could be constified some day, this code
> will prevent such (good) thing.

Thank you for your suggestion. I will consider that with Patch 3/3.

> 
> Cheers,
> 
> Paolo