linux-kernel - Re: [v2] usb: xhci: Add error handling in xhci_map_urb_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 29 Feb 2024 16:15:12 +0200
From: Mathias Nyman <mathias.nyman@...ux.intel.com>
To: Prashanth K <quic_prashk@...cinc.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Mathias Nyman <mathias.nyman@...el.com>
Cc: Sergei Shtylyov <sergei.shtylyov@...il.com>,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [v2] usb: xhci: Add error handling in xhci_map_urb_for_dma

On 28.2.2024 14.57, Prashanth K wrote:
> Currently xhci_map_urb_for_dma() creates a temporary buffer
> and copies the SG list to the new linear buffer. But if the
> kzalloc_node() fails, then the following sg_pcopy_to_buffer()
> can lead to crash since it tries to memcpy to NULL pointer.
> So return -ENOMEM if kzalloc returns null pointer.
> 
> Cc: <stable@...r.kernel.org> # 5.11
> Fixes: 2017a1e58472 ("usb: xhci: Use temporary buffer to consolidate SG")
> Signed-off-by: Prashanth K <quic_prashk@...cinc.com>
> ---

Thanks.

Added

-Mathias