linux-kernel - Re: [PATCH 1/3] dt-bindings: display: mediatek: gamma: Change MT8195 to single enum group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <30e7d78a5ea266c39865d78ff6eb7eede2a01f3f.camel@mediatek.com>
Date: Thu, 29 Feb 2024 14:38:15 +0000
From: Jason-JH Lin (林睿祥) <Jason-JH.Lin@...iatek.com>
To: "matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"chunkuang.hu@...nel.org" <chunkuang.hu@...nel.org>,
	"angelogioacchino.delregno@...labora.com"
	<angelogioacchino.delregno@...labora.com>, "robh+dt@...nel.org"
	<robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	Singo Chang (張興國) <Singo.Chang@...iatek.com>,
	Johnson Wang (王聖鑫) <Johnson.Wang@...iatek.com>,
	"linaro-mm-sig@...ts.linaro.org" <linaro-mm-sig@...ts.linaro.org>,
	"linux-media@...r.kernel.org" <linux-media@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	Jason-ch Chen (陳建豪)
	<Jason-ch.Chen@...iatek.com>, Shawn Sung (宋孝謙)
	<Shawn.Sung@...iatek.com>, Nancy Lin (林欣螢)
	<Nancy.Lin@...iatek.com>, "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>, Project_Global_Chrome_Upstream_Group
	<Project_Global_Chrome_Upstream_Group@...iatek.com>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "fshao@...omium.org"
	<fshao@...omium.org>
Subject: Re: [PATCH 1/3] dt-bindings: display: mediatek: gamma: Change MT8195
 to single enum group

Hi Angelo,

Thanks for the reviews.

On Thu, 2024-02-29 at 09:47 +0100, AngeloGioacchino Del Regno wrote:
> Il 29/02/24 03:35, Jason-JH.Lin ha scritto:
> > Since MT8195 gamma has multiple bank for 12 bits LUT and it is
> > different from any other SoC LUT setting.
> > 
> > So we move MT8195 compatible from the one of items to the
> > single enum group.
> > 
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@...iatek.com>
> > ---
> >   .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml    |
> > 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > index c6641acd75d6..3e6cb8f48bcc 100644
> > ---
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma
> > .yaml
> > @@ -24,6 +24,7 @@ properties:
> >         - enum:
> >             - mediatek,mt8173-disp-gamma
> >             - mediatek,mt8183-disp-gamma
> > +          - mediatek,mt8195-disp-gamma
> >         - items:
> >             - enum:
> >                 - mediatek,mt6795-disp-gamma
> > @@ -33,7 +34,6 @@ properties:
> >                 - mediatek,mt8186-disp-gamma
> >                 - mediatek,mt8188-disp-gamma
> >                 - mediatek,mt8192-disp-gamma
> > -              - mediatek,mt8195-disp-gamma
> 
> While I agree on allowing mt8195-disp-gamma to have its own separated
> compatible
> as the IP is actually different from the one in MT8183, you can't do
> it like that,
> or dtbs_check will fail validation for the mt8195 devicetree.
> 
OK, I'll keep mt8195 here to fix the validation.

> That one declares...
> 
> gamma0: gamma@...06000 {
> 	compatible = "mediatek,mt8195-disp-gamma", "mediatek,mt8183-
> disp-gamma";
> 
> ...Please always run dtbs_check when performing bindings
> modifications.
> 
I'm sorry about that.
I found that I have never run dtbs_check successfully because
the dtbs_check did not appear in my environment after I ran
dt_binding_check...

Finally, I found that using "make dt_binding_check dtbs_check" in the
same cmd line works!
So I'll always do this before sending bindings modification.

Regards,
Jason-JH.Lin

> Cheers,
> Angelo
> 
> >             - const: mediatek,mt8183-disp-gamma
> >   
> >     reg:
> 
>