linux-kernel - [PATCH] greybus: Fix deref of NULL in __gb_lights_flash_brightness

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240301190425.120605-1-m.lobanov@rosalinux.ru>
Date: Fri,  1 Mar 2024 14:04:24 -0500
From: Mikhail Lobanov <m.lobanov@...alinux.ru>
To: Rui Miguel Silva <rmfrfs@...il.com>
Cc: Mikhail Lobanov <m.lobanov@...alinux.ru>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	greybus-dev@...ts.linaro.org,
	linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: [PATCH] greybus: Fix deref of NULL in __gb_lights_flash_brightness_set

Dereference of null pointer in the __gb_lights_flash_brightness_set function.
Assigning the channel the result of executing the get_channel_from_mode function
without checking for NULL may result in an error.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 2870b52bae4c ("greybus: lights: add lights implementation")
Signed-off-by: Mikhail Lobanov <m.lobanov@...alinux.ru>
---
 drivers/staging/greybus/light.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/light.c b/drivers/staging/greybus/light.c
index 87d36948c610..929514350947 100644
--- a/drivers/staging/greybus/light.c
+++ b/drivers/staging/greybus/light.c
@@ -148,10 +148,15 @@ static int __gb_lights_flash_brightness_set(struct gb_channel *channel)
 						GB_CHANNEL_MODE_TORCH);
 
 	/* For not flash we need to convert brightness to intensity */
-	intensity = channel->intensity_uA.min +
+
+	if (channel) {
+		intensity = channel->intensity_uA.min +
 			(channel->intensity_uA.step * channel->led->brightness);
 
-	return __gb_lights_flash_intensity_set(channel, intensity);
+		return __gb_lights_flash_intensity_set(channel, intensity);
+	}
+
+	return 0;
 }
 #else
 static struct gb_channel *get_channel_from_cdev(struct led_classdev *cdev)
-- 
2.43.0