linux-kernel - Re: [PATCH] lib/stackdepot: off by one in depot_fetch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+fCnZdubN6xDS2adjX5jEgBOWy5KRBaHrs3COa_CG-ePFHkuQ@mail.gmail.com>
Date: Fri, 1 Mar 2024 20:23:05 +0100
From: Andrey Konovalov <andreyknvl@...il.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>, Alexander Potapenko <glider@...gle.com>, 
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org, 
	Marco Elver <elver@...gle.com>
Subject: Re: [PATCH] lib/stackdepot: off by one in depot_fetch_stack()

On Thu, Feb 29, 2024 at 8:22 AM Dan Carpenter <dan.carpenter@...aroorg> wrote:
>
> I wrote it on top of that patch...

Ah, right, my bad.

> Backports will need to be adjusted
> to handle it, I guess.  The "lib/stackdepot: fix first entry having a
> 0-handle" commit has this note:
>
>     This bug has been lurking since the very beginning of stackdepot, but no
>     one really cared as it seems.  Because of that I am not adding a Fixes
>     tag.
>
> I don't really know the code very well so I can't respond to that.

Your patch looks good to me, thank you!

Reviewed-by: Andrey Konovalov <andreyknvl@...il.com>