[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <170932612275.398.5909023853768866399.tip-bot2@tip-bot2>
Date: Fri, 01 Mar 2024 20:48:42 -0000
From: "tip-bot2 for Thomas Gleixner" <tip-bot2@...utronix.de>
To: linux-tip-commits@...r.kernel.org
Cc: Thomas Gleixner <tglx@...utronix.de>,
"Borislav Petkov (AMD)" <bp@...en8.de>, x86@...nel.org,
linux-kernel@...r.kernel.org
Subject: [tip: x86/core] x86/idle: Clean up idle selection
The following commit has been merged into the x86/core branch of tip:
Commit-ID: 18a9f4806dcb33ed7eab93232d13facf5c6e2b70
Gitweb: https://git.kernel.org/tip/18a9f4806dcb33ed7eab93232d13facf5c6e2b70
Author: Thomas Gleixner <tglx@...utronix.de>
AuthorDate: Thu, 29 Feb 2024 15:23:38 +01:00
Committer: Borislav Petkov (AMD) <bp@...en8.de>
CommitterDate: Fri, 01 Mar 2024 21:33:12 +01:00
x86/idle: Clean up idle selection
Clean up the code to make it readable. No functional change.
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>
Link: https://lore.kernel.org/r/20240229142248.392017685@linutronix.de
---
arch/x86/kernel/process.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
index 5853d56..b6512f7 100644
--- a/arch/x86/kernel/process.c
+++ b/arch/x86/kernel/process.c
@@ -910,11 +910,13 @@ static __cpuidle void mwait_idle(void)
void select_idle_routine(const struct cpuinfo_x86 *c)
{
-#ifdef CONFIG_SMP
- if (boot_option_idle_override == IDLE_POLL && smp_num_siblings > 1)
- pr_warn_once("WARNING: polling idle and HT enabled, performance may degrade\n");
-#endif
- if (x86_idle_set() || boot_option_idle_override == IDLE_POLL)
+ if (boot_option_idle_override == IDLE_POLL) {
+ if (IS_ENABLED(CONFIG_SMP) && smp_num_siblings > 1)
+ pr_warn_once("WARNING: polling idle and HT enabled, performance may degrade\n");
+ return;
+ }
+
+ if (x86_idle_set())
return;
if (prefer_mwait_c1_over_halt(c)) {
Powered by blists - more mailing lists