[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <65e24e516d330_314b33294f@iweiny-mobl.notmuch>
Date: Fri, 1 Mar 2024 13:53:21 -0800
From: Ira Weiny <ira.weiny@...el.com>
To: Dan Williams <dan.j.williams@...el.com>, Ira Weiny <ira.weiny@...el.com>,
Jonathan Cameron <jonathan.cameron@...wei.com>, Smita Koralahalli
<Smita.KoralahalliChannabasappa@....com>, Shiju Jose <shiju.jose@...wei.com>
CC: Dan Carpenter <dan.carpenter@...aro.org>, Yazen Ghannam
<yazen.ghannam@....com>, Davidlohr Bueso <dave@...olabs.net>, Dave Jiang
<dave.jiang@...el.com>, Alison Schofield <alison.schofield@...el.com>, Vishal
Verma <vishal.l.verma@...el.com>, Ard Biesheuvel <ardb@...nel.org>,
<linux-efi@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<linux-cxl@...r.kernel.org>, Ira Weiny <ira.weiny@...el.com>
Subject: Re: [PATCH 1/4] cxl/event: Add missing include files
Dan Williams wrote:
> Ira Weiny wrote:
> > Additional event testing using the cxl-event.h header revealed that it
> > did not include the correct headers for the types used. Compile errors
> > such as:
> >
> > include/linux/cxl-event.h|11 col 9| error: unknown type name ‘u8’
> >
> > ... were seen.
>
> Were seen where? Should this have the trio of Reported-by: Closes: and
> Fixes tags?
As I said after this in the commit message:
"Omit the fixes tag because this does not cause any issues until
the header is used again in other code."
I'll clarify it was seen when I used cxl-event.h in the testing code and
this happened.
Ira
Powered by blists - more mailing lists