linux-kernel - Re: [PATCH v2 3/7] tracing/probes: cleanup: Set trace_probe::nr_args at trace_probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 29 Feb 2024 22:37:53 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: "Masami Hiramatsu (Google)" <mhiramat@...nel.org>
Cc: Jiri Olsa <jolsa@...nel.org>, linux-kernel@...r.kernel.org,
 linux-trace-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v2 3/7] tracing/probes: cleanup: Set
 trace_probe::nr_args at trace_probe_init

On Mon, 26 Feb 2024 12:58:23 +0900
"Masami Hiramatsu (Google)" <mhiramat@...nel.org> wrote:

> From: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> 
> Instead of incrementing the trace_probe::nr_args, init it at trace_probe_init().
> This is a cleanup, so the behavior is not changed.

The change is fine, but the change log does not say why this was done.

Reviewed-by: Steven Rostedt (Google) <rostedt@...dmis.org>

-- Steve


> 
> Signed-off-by: Masami Hiramatsu (Google) <mhiramat@...nel.org>
> ---