linux-kernel - [PATCH 2/2] power: supply: core: simplify power_supply_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240301-psy-class-cleanup-v1-2-aebe8c4b6b08@collabora.com>
Date: Fri, 01 Mar 2024 23:58:27 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Linus Walleij <linus.walleij@...aro.org>, 
 "Ricardo B. Marliere" <ricardo@...liere.net>, 
 Sebastian Reichel <sre@...nel.org>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, 
 Sebastian Reichel <sebastian.reichel@...labora.com>
Subject: [PATCH 2/2] power: supply: core: simplify power_supply_class_init

Technically the sysfs attributes should be initialized
before the class is registered, since that will use them.
As a nice side effect this nicely simplifies the code,
since it allows dropping the helper variable.

Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
---
 drivers/power/supply/power_supply_core.c | 9 +--------
 1 file changed, 1 insertion(+), 8 deletions(-)

diff --git a/drivers/power/supply/power_supply_core.c b/drivers/power/supply/power_supply_core.c
index 0eb8a57dda70..4daea6ed8f1d 100644
--- a/drivers/power/supply/power_supply_core.c
+++ b/drivers/power/supply/power_supply_core.c
@@ -1622,15 +1622,8 @@ EXPORT_SYMBOL_GPL(power_supply_get_drvdata);

 static int __init power_supply_class_init(void)
 {
-	int err;
-
-	err = class_register(&power_supply_class);
-	if (err)
-		return err;
-
 	power_supply_init_attrs();
-
-	return 0;
+	return class_register(&power_supply_class);
 }

 static void __exit power_supply_class_exit(void)

-- 
2.43.0