linux-kernel - Re: [PATCH v3 3/4] ASoC: dt-bindings: fsl-sai: allow only one dma-names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeFUV/xFrYnZzXZw@lizhi-Precision-Tower-5810>
Date: Thu, 29 Feb 2024 23:06:47 -0500
From: Frank Li <Frank.li@....com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Shengjiu Wang <shengjiu.wang@....com>, linux-sound@...r.kernel.org,
	devicetree@...r.kernel.org, imx@...ts.linux.dev,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 3/4] ASoC: dt-bindings: fsl-sai: allow only one
 dma-names

On Thu, Feb 29, 2024 at 10:46:38AM +0100, Krzysztof Kozlowski wrote:
> On 28/02/2024 20:14, Frank Li wrote:
> > Some sai only connect one direction. So allow only "rx" or "tx" for
> > dma-names.
> 
> "one direction" was already allowed. Explain really what is the
> different, e.g. you expect only TX?

Yes, there are one sai only connect tx dma channel.

So TX \ RX \ both TX and RX, 3 kind combination.

> 
> This applies to all your recent patches - they all have insufficient
> explanation. Often they explain what you are doing, but not why.
> 
> > 
> > Signed-off-by: Frank Li <Frank.Li@....com>
> 
> 
> 
> 
> Best regards,
> Krzysztof
>