[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <32b39767-2ba7-436c-8f76-01d07f01193b@linux.vnet.ibm.com>
Date: Fri, 1 Mar 2024 10:36:41 +0530
From: Tasmiya Nalatwad <tasmiya@...ux.vnet.ibm.com>
To: Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>
Cc: Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
arkadiusz.kubalewski@...el.com, jiri@...dia.com,
venkat88@...ux.vnet.ibm.com,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>
Subject: Re: [revert 0d60d8df6f49] [net/net-next] [6.8-rc5] Build Failure
Greetings,
This is tied to gcc version. Build failure is seen while using gcc-8.5.x
On 2/29/24 20:17, Jakub Kicinski wrote:
> On Thu, 29 Feb 2024 09:55:22 +0100 Eric Dumazet wrote:
>> I do not see other solution than this, otherwise we have to add more
>> pollution to include/linux/netdevice.h
> Right :(
>
>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
>> index a9c973b92294bb110cf3cd336485972127b01b58..40797ea80bc6273cae6b7773d0a3e47459a72150
>> 100644
>> --- a/include/linux/netdevice.h
>> +++ b/include/linux/netdevice.h
>> @@ -2469,7 +2469,7 @@ struct net_device {
>> struct devlink_port *devlink_port;
>>
>> #if IS_ENABLED(CONFIG_DPLL)
>> - struct dpll_pin __rcu *dpll_pin;
>> + void __rcu *dpll_pin;
>> #endif
> If DPLL wants to hide its type definitions the helpers must live
> in dpll? IOW move netdev_dpll_pin() to drivers/dpll/dpll_core.c
>
> BTW Tasmiya, please do tell us what compiler you're using.
>
--
Regards,
Tasmiya Nalatwad
IBM Linux Technology Center
Powered by blists - more mailing lists