linux-kernel - Re: [PATCH v3 2/5] arm64: dts: rockchip: enable automatic active cooling on Rock 5B

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABjd4YybaQnKm+VpU_xVrCb=pxQ7oQXPHGZzn_u1w_h3yn7gwg@mail.gmail.com>
Date: Fri, 1 Mar 2024 09:21:30 +0400
From: Alexey Charkov <alchark@...il.com>
To: Dragan Simic <dsimic@...jaro.org>
Cc: Rob Herring <robh+dt@...nel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, 
	Heiko Stuebner <heiko@...ech.de>, Daniel Lezcano <daniel.lezcano@...aro.org>, 
	Viresh Kumar <viresh.kumar@...aro.org>, Chen-Yu Tsai <wens@...nel.org>, devicetree@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/5] arm64: dts: rockchip: enable automatic active
 cooling on Rock 5B

On Fri, Mar 1, 2024 at 1:25 AM Dragan Simic <dsimic@...jaro.org> wrote:
>
> Hello Alexey,
>
> On 2024-02-29 20:26, Alexey Charkov wrote:
> > This links the PWM fan on Radxa Rock 5B as an active cooling device
> > managed automatically by the thermal subsystem, with a target SoC
> > temperature of 65C and a minimum-spin interval from 55C to 65C to
> > ensure airflow when the system gets warm
>
> I'd suggest that you replace "automatic active cooling" with "active
> cooling" in the patch subject.  I know, it may seem like more of the
> unnecessary nitpicking, :) but I hope you'll agree that "automatic"
> is actually redundant there.  It would also make the patch subject
> a bit shorter.
>
> Another option would be to replace "automatic active cooling" with
> "automatic fan control", which may actually be a better choice.
> I'd be happy with whichever one you prefer. :)

Sounds good to me, thanks!

> Otherwise, please feel free to add:
>
> Reviewed-by: Dragan Simic <dsimic@...jaro.org>

Thank you Dragan, much appreciated!

Best regards,
Alexey