lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Fri, 1 Mar 2024 07:59:35 +0000
From: Lee Jones <lee@...nel.org>
To: Conor Dooley <conor@...nel.org>
Cc: netdev@...r.kernel.org, Conor Dooley <conor.dooley@...rochip.com>,
	Rob Herring <robh@...nel.org>, Pavel Machek <pavel@....cz>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sven Schwermer <sven.schwermer@...ruptive-technologies.com>,
	Christian Marangi <ansuelsmth@...il.com>,
	linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [RESEND] dt-bindings: leds: pwm-multicolour: re-allow active-low

On Thu, 29 Feb 2024, Conor Dooley wrote:

> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> active-low was lifted to the common schema for leds, but it went
> unnoticed that the leds-multicolour binding had "additionalProperties:
> false" where the other users had "unevaluatedProperties: false", thereby
> disallowing active-low for multicolour leds. Explicitly permit it again.
> 
> Fixes: c94d1783136e ("dt-bindings: net: phy: Make LED active-low property common")
> Acked-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>
> ---
> 
> This needs to go via netdev as the commit it fixes (and is based on)
> is there
> 
> CC: Pavel Machek <pavel@....cz>
> CC: Lee Jones <lee@...nel.org>
> CC: Rob Herring <robh@...nel.org>
> CC: Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
> CC: Conor Dooley <conor+dt@...nel.org>
> CC: Sven Schwermer <sven.schwermer@...ruptive-technologies.com>
> CC: Christian Marangi <ansuelsmth@...il.com>
> CC: linux-leds@...r.kernel.org
> CC: devicetree@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> CC: "David S. Miller" <davem@...emloft.net>
> CC: Eric Dumazet <edumazet@...gle.com>
> CC: Jakub Kicinski <kuba@...nel.org>
> CC: Paolo Abeni <pabeni@...hat.com>
> CC: netdev@...r.kernel.org
> ---
>  Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml | 2 ++
>  1 file changed, 2 insertions(+)

Please take this via netdev.

Acked-by: Lee Jones <lee@...nel.org>

> diff --git a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> index 5edfbe347341..a31a202afe5c 100644
> --- a/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> +++ b/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
> @@ -41,6 +41,8 @@ properties:
>  
>            pwm-names: true
>  
> +          active-low: true
> +
>            color: true
>  
>          required:
> -- 
> 2.43.0
> 
> 

-- 
Lee Jones [李琼斯]

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ