linux-kernel - Re: [PATCH] USB: usb-storage: Prevent divide-by-0 error in isd200_ata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1frxazrgx.fsf@ca-mkp.ca.oracle.com>
Date: Thu, 29 Feb 2024 20:11:35 -0500
From: "Martin K. Petersen" <martin.petersen@...cle.com>
To: Alan Stern <stern@...land.harvard.edu>
Cc: Greg KH <gregkh@...uxfoundation.org>,
        syzbot
 <syzbot+28748250ab47a8f04100@...kaller.appspotmail.com>,
        bvanassche@....org, emilne@...hat.com, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, martin.petersen@...cle.com,
        nogikh@...gle.com, syzkaller-bugs@...glegroups.com, tasos@...ossah.com,
        usb-storage@...ts.one-eyed-alien.net
Subject: Re: [PATCH] USB: usb-storage: Prevent divide-by-0 error in
 isd200_ata_command


Alan,

> The isd200 sub-driver in usb-storage uses the HEADS and SECTORS values
> in the ATA ID information to calculate cylinder and head values when
> creating a CDB for READ or WRITE commands. The calculation involves
> division and modulus operations, which will cause a crash if either of
> these values is 0. While this never happens with a genuine device, it
> could happen with a flawed or subversive emulation, as reported by the
> syzbot fuzzer.

Looks good to me.

Reviewed-by: Martin K. Petersen <martin.petersen@...cle.com>

-- 
Martin K. Petersen	Oracle Linux Engineering