linux-kernel - Re: [PATCH v3 00/10] Make PCI's devres API more consistent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7158e09386f0345d2e87ea5433dabf38db027971.camel@redhat.com>
Date: Fri, 01 Mar 2024 10:29:42 +0100
From: Philipp Stanner <pstanner@...hat.com>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Hans de Goede <hdegoede@...hat.com>, Maarten Lankhorst
 <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
 Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>, Bjorn Helgaas <bhelgaas@...gle.com>, Sam
 Ravnborg <sam@...nborg.org>, dakr@...hat.com, 
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
 linux-pci@...r.kernel.org
Subject: Re: [PATCH v3 00/10] Make PCI's devres API more consistent

On Thu, 2024-02-29 at 14:57 -0600, Bjorn Helgaas wrote:
> On Thu, Feb 29, 2024 at 09:31:20AM +0100, Philipp Stanner wrote:
> > @Bjorn:
> > Hey Bjorn, are we good with this series? Any more wishes or
> > suggestions?
> 
> Sorry, haven't had a chance to go through it yet.  
> 
> FWIW, I just tried to apply these on top of pci/devres, but it failed
> here:
> 
>   Applying: PCI: Add new set of devres functions
>   Applying: PCI: Deprecate iomap-table functions
>   Applying: PCI: Warn users about complicated devres nature
>   Applying: PCI: Make devres region requests consistent
>   Applying: PCI: Move dev-enabled status bit to struct pci_dev
>   error: patch failed: drivers/pci/pci.h:811
>   error: drivers/pci/pci.h: patch does not apply
>   Patch failed at 0005 PCI: Move dev-enabled status bit to struct
> pci_dev
> 
> Haven't investigated, so maybe it's some trivial easily fixed thing.

For me, based on Linus's master, this applies with the previous series.

It seems to me that this issue only exists on linux-next, the reason
being that git searches for struct pci_devres in line 811, but on
linux-next, because of previous additions, the struct moved to line
827, and poor git can't find it anymore.

I could fix that and provide a v4.


P.


> 
> Bjorn
>