lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date: Fri, 1 Mar 2024 11:20:26 +0100
From: Markus Elfring <Markus.Elfring@....de>
To: linux-media@...r.kernel.org, kernel-janitors@...r.kernel.org,
 Eugen Hristev <eugen.hristev@...labora.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] media: microchip-csi2dc: Move a fwnode_handle_put() call into
 an if branch in csi2dc_of_parse()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Fri, 1 Mar 2024 11:11:44 +0100

Move a fwnode_handle_put() call into an if branch of this function
so that the control flow looks a bit safer directly.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/media/platform/microchip/microchip-csi2dc.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/media/platform/microchip/microchip-csi2dc.c b/drivers/media/platform/microchip/microchip-csi2dc.c
index fee73260bb1e..ed800a3bb268 100644
--- a/drivers/media/platform/microchip/microchip-csi2dc.c
+++ b/drivers/media/platform/microchip/microchip-csi2dc.c
@@ -595,12 +595,11 @@ static int csi2dc_of_parse(struct csi2dc_device *csi2dc,

 	output_fwnode = fwnode_graph_get_next_endpoint
 				(of_fwnode_handle(of_node), input_fwnode);
-
-	if (output_fwnode)
+	if (output_fwnode) {
 		ret = v4l2_fwnode_endpoint_parse(output_fwnode,
 						 &output_endpoint);
-
-	fwnode_handle_put(output_fwnode);
+		fwnode_handle_put(output_fwnode);
+	}

 	if (!output_fwnode || ret) {
 		dev_info(csi2dc->dev,
--
2.44.0


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ