linux-kernel - Re: [PATCH v8 03/10] clk: eyeq5: add platform driver, and init routine at of_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd72dbb31387cd4e2551189d8d10d3a6.sboyd@kernel.org>
Date: Thu, 29 Feb 2024 17:33:10 -0800
From: Stephen Boyd <sboyd@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>, Théo Lebrun <theo.lebrun@...tlin.com>
Cc: Gregory CLEMENT <gregory.clement@...tlin.com>, Michael Turquette <mturquette@...libre.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley <conor+dt@...nel.org>, Thomas Bogendoerfer <tsbogend@...ha.franken.de>, Linus Walleij <linus.walleij@...aro.org>, Rafał Miłecki <rafal@...ecki.pl>, Philipp Zabel <p.zabel@...gutronix.de>, Vladimir Kondratiev <vladimir.kondratiev@...ileye.com>, linux-mips@...r.kernel.org, linux-clk@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, Tawfik Bayouk <tawfik.bayouk@...ileye.com>, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v8 03/10] clk: eyeq5: add platform driver, and init routine at of_clk_init()

Quoting Théo Lebrun (2024-02-29 07:40:25)
> Hello,
> 
> On Thu Feb 29, 2024 at 3:59 PM CET, Andy Shevchenko wrote:
> > On Thu, Feb 29, 2024 at 03:27:01PM +0100, Théo Lebrun wrote:
> > > On Wed, Feb 28, 2024 at 03:33:29PM +0100, Théo Lebrun wrote:
> > > > On Tue Feb 27, 2024 at 6:11 PM CET, Andy Shevchenko wrote:
> > > > > On Tue, Feb 27, 2024 at 03:55:24PM +0100, Théo Lebrun wrote:
> 
> > 2) Still I see a benefit from using lo_hi_readq() and friends directly.
> 
> So it is:
> 
>         u32 r0 = readl(base_plls + pll->reg64);
>         u32 r1 = readl(base_plls + pll->reg64 + sizeof(r0));
> 
> vs:
> 
>         u64 r = lo_hi_readq(base_plls + pll->regs64);
>         u32 r0 = r;
>         u32 r1 = r >> 32;
> 
> One is straight forward, the other uses an obscure helper that code
> readers must understand and follows that with bit manipulation.
> 

Just use readq() and include the correct header please. We know what
readq() is in the kernel.