linux-kernel - Re: [PATCH net-next v5 06/16] net: dsa: vsc73xx: add port_stp_state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 1 Mar 2024 19:35:51 +0800
From: kernel test robot <lkp@...el.com>
To: Pawel Dembicki <paweldembicki@...il.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, linus.walleij@...aro.org,
	Pawel Dembicki <paweldembicki@...il.com>,
	Andrew Lunn <andrew@...n.ch>,
	Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Claudiu Manoil <claudiu.manoil@....com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	UNGLinuxDriver@...rochip.com, Russell King <linux@...linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5 06/16] net: dsa: vsc73xx: add
 port_stp_state_set function

Hi Pawel,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Pawel-Dembicki/net-dsa-vsc73xx-use-read_poll_timeout-instead-delay-loop/20240224-050950
base:   net-next/main
patch link:    https://lore.kernel.org/r/20240223210049.3197486-7-paweldembicki%40gmail.com
patch subject: [PATCH net-next v5 06/16] net: dsa: vsc73xx: add port_stp_state_set function
config: x86_64-randconfig-161-20240301 (https://download.01.org/0day-ci/archive/20240301/202403011918.VO71zUCH-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403011918.VO71zUCH-lkp@intel.com/

smatch warnings:
drivers/net/dsa/vitesse-vsc73xx-core.c:1054 vsc73xx_refresh_fwd_map() warn: inconsistent indenting

vim +1054 drivers/net/dsa/vitesse-vsc73xx-core.c

  1031	
  1032	static void vsc73xx_refresh_fwd_map(struct dsa_switch *ds, int port, u8 state)
  1033	{
  1034		struct dsa_port *other_dp, *dp = dsa_to_port(ds, port);
  1035		struct vsc73xx *vsc = ds->priv;
  1036		u16 mask;
  1037	
  1038		if (state != BR_STATE_FORWARDING) {
  1039			/* Ports that aren't in the forwarding state must not
  1040			 * forward packets anywhere.
  1041			 */
  1042			vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER, 0,
  1043					    VSC73XX_SRCMASKS + port,
  1044					    VSC73XX_SRCMASKS_PORTS_MASK, 0);
  1045	
  1046			dsa_switch_for_each_available_port(other_dp, ds) {
  1047				if (other_dp == dp)
  1048					continue;
  1049				vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER, 0,
  1050						    VSC73XX_SRCMASKS + other_dp->index,
  1051						    BIT(port), 0);
  1052			}
  1053	
> 1054		return;
  1055		}
  1056	
  1057		/* Forwarding ports must forward to the CPU and to other ports
  1058		 * in the same bridge
  1059		 */
  1060		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER, 0,
  1061				    VSC73XX_SRCMASKS + CPU_PORT, BIT(port), BIT(port));
  1062	
  1063		mask = BIT(CPU_PORT);
  1064	
  1065		if (dp->bridge) {
  1066			dsa_switch_for_each_user_port(other_dp, ds) {
  1067				if (other_dp->bridge == dp->bridge &&
  1068				    other_dp->index != port &&
  1069				    other_dp->stp_state == BR_STATE_FORWARDING) {
  1070					int other_port = other_dp->index;
  1071	
  1072					mask |= BIT(other_port);
  1073					vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER,
  1074							    0,
  1075							    VSC73XX_SRCMASKS +
  1076							    other_port,
  1077							    BIT(port), BIT(port));
  1078				}
  1079			}
  1080		}
  1081	
  1082		vsc73xx_update_bits(vsc, VSC73XX_BLOCK_ANALYZER, 0,
  1083				    VSC73XX_SRCMASKS + port,
  1084				    VSC73XX_SRCMASKS_PORTS_MASK, mask);
  1085	}
  1086	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki