linux-kernel - Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2d5f9cd5-a2c2-453e-aa52-a84a86107d1f@sirena.org.uk>
Date: Fri, 1 Mar 2024 12:11:56 +0000
From: Mark Brown <broonie@...nel.org>
To: Ryan Roberts <ryan.roberts@....com>
Cc: Aishwarya TCV <aishwarya.tcv@....com>, Zi Yan <ziy@...dia.com>,
	"Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>,
	linux-mm@...ck.org, "Matthew Wilcox (Oracle)" <willy@...radead.org>,
	David Hildenbrand <david@...hat.com>,
	Yang Shi <shy828301@...il.com>, Yu Zhao <yuzhao@...gle.com>,
	"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
	Michal Koutný <mkoutny@...e.com>,
	Roman Gushchin <roman.gushchin@...ux.dev>,
	Zach O'Keefe <zokeefe@...gle.com>, Hugh Dickins <hughd@...gle.com>,
	Luis Chamberlain <mcgrof@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge
 pages to any order.

On Fri, Mar 01, 2024 at 10:33:15AM +0000, Ryan Roberts wrote:

>   - In create_pagecache_thp_and_fd() you do *fd = open(testfile, O_CREAT ...);
>     where testfile is /mnt/thp_fs/testfile. So if /mnt/thp_fs doesn't exist,
>     then the open will fail I think? I'm pretty sure that's what's happening on
>     our CI. Suggest the test needs to setup this dir itself. Is thp_fs a mounted
>     fs or just a dir? If the latter can you just mktemp()?

Mounting on /mnt would also be a bit of an issue, that's something
people are relatively likely to have used for something so could be
disruptive.  If the test is going to do a new mount it's probably better
to do something like make a temporary directory then mount on top of that.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)