[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <7198ce13-bccf-4835-aa14-ca45eed1f066@linaro.org>
Date: Fri, 1 Mar 2024 15:56:25 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Alexey Romanov <avromanov@...utedevices.com>, neil.armstrong@...aro.org,
clabbe@...libre.com, herbert@...dor.apana.org.au, davem@...emloft.net,
robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
khilman@...libre.com, jbrunet@...libre.com,
martin.blumenstingl@...glemail.com, vadim.fedorenko@...ux.dev
Cc: linux-crypto@...r.kernel.org, linux-amlogic@...ts.infradead.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, kernel@...utedevices.com
Subject: Re: [PATCH v5 17/21] dt-bindings: crypto: meson: support new SoC's
On 01/03/2024 14:29, Alexey Romanov wrote:
> Now crypto module available at G12A/G12B/S4/A1/SM1/AXG.
>
> @@ -11,8 +11,16 @@ maintainers:
>
> properties:
> compatible:
> - items:
> - - const: amlogic,gxl-crypto
> + oneOf:
> + - items:
> + - enum:
> + - amlogic,s4-crypto
> + - const: amlogic,a1-crypto
> + - enum:
> + - amlogic,gxl-crypto
> + - amlogic,axg-crypto
> + - amlogic,g12a-crypto
> + - amlogic,a1-crypto
>
> reg:
> maxItems: 1
> @@ -21,10 +29,14 @@ properties:
> items:
> - description: Interrupt for flow 0
> - description: Interrupt for flow 1
> + minItems: 1
>
> clocks:
> maxItems: 1
>
> + power-domains:
> + maxItems: 1
> +
Don't break the order. names always follow given entry.
> clock-names:
> const: blkmv
>
> @@ -32,8 +44,24 @@ required:
> - compatible
> - reg
> - interrupts
> - - clocks
> - - clock-names
> +
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: amlogic,gxl-crypto
> + then:
> + required:
> + - clocks
> + - clock-names
> + properties:
First properties, then required.
> + interrupts:
> + maxItems: 2
> + else:
> + properties:
> + interrupts:
> + maxItems: 1
clocks: false
clock-names: false
>
Best regards,
Krzysztof
Powered by blists - more mailing lists