[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240301-uphold-numerous-305c3702805b@spud>
Date: Fri, 1 Mar 2024 16:23:30 +0000
From: Conor Dooley <conor@...nel.org>
To: Animesh Agarwal <animeshagarwal28@...il.com>
Cc: mdf@...nel.org, Wu Hao <hao.wu@...el.com>,
Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, linux-fpga@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: altera-fpga2sdram-bridge: Convert to
dtschema
Hey,
On Fri, Mar 01, 2024 at 09:46:43PM +0530, Animesh Agarwal wrote:
> Convert the altera-fpga2sdram-bridge bindings to DT schema.
>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@...il.com>
> ---
> .../fpga/altera-fpga2sdram-bridge.txt | 13 -----------
> .../fpga/altera-fpga2sdram-bridge.yaml | 23 +++++++++++++++++++
> 2 files changed, 23 insertions(+), 13 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> create mode 100644 Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
>
> diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> deleted file mode 100644
> index 5dd0ff0f7b4e..000000000000
> --- a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.txt
> +++ /dev/null
> @@ -1,13 +0,0 @@
> -Altera FPGA To SDRAM Bridge Driver
> -
> -Required properties:
> -- compatible : Should contain "altr,socfpga-fpga2sdram-bridge"
> -
> -See Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
> -
> -Example:
> - fpga_bridge3: fpga-bridge@...25080 {
> - compatible = "altr,socfpga-fpga2sdram-bridge";
> - reg = <0xffc25080 0x4>;
> - bridge-enable = <0>;
> - };
> diff --git a/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> new file mode 100644
> index 000000000000..88bf9e3151b6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/altera-fpga2sdram-bridge.yaml
> @@ -0,0 +1,23 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/fpga/altr-fpga2sdram-bridge.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Altera FPGA To SDRAM Bridge Driver
> +
You're missing maintainers: (shouldn't dt_binding_check complain?)
> +properties:
> + compatible:
> + enum:
> + - altr,socfpga-fpga2sdram-bridge
> +
> +required:
> + - compatible
> +
Missing "unevaluatedProperties: false".
> +examples:
> + - |
> + fpga_bridge3: fpga-bridge@...25080 {
> + compatible = "altr,socfpga-fpga2sdram-bridge";
> + reg = <0xffc25080 0x4>;
> + bridge-enable = <0>;
This has not been documented in your binding. You need a ref to
fpga-bridge.yaml. Did you test this patch?
Cheers,
Conor.
> + };
> --
> 2.44.0
>
Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)
Powered by blists - more mailing lists