linux-kernel - Re: [PATCH] staging: media: tegra-video: Use common error handling code in tegra_vi_graph_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f1b617f-06cb-4b22-a050-325424720c57@moroto.mountain>
Date: Sat, 2 Mar 2024 12:30:41 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Markus Elfring <Markus.Elfring@....de>, linux-staging@...ts.linux.dev,
	linux-tegra@...r.kernel.org, linux-media@...r.kernel.org,
	kernel-janitors@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Sowjanya Komatineni <skomatineni@...dia.com>,
	Thierry Reding <thierry.reding@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: media: tegra-video: Use common error handling
 code in tegra_vi_graph_parse_one()

On Fri, Mar 01, 2024 at 06:39:36PM +0100, Luca Ceresoli wrote:
> Hello Markus,
> 
> On Thu, 29 Feb 2024 19:55:46 +0100
> Markus Elfring <Markus.Elfring@....de> wrote:
> 
> > From: Markus Elfring <elfring@...rs.sourceforge.net>
> > Date: Thu, 29 Feb 2024 19:44:36 +0100
> > 
> > Add a jump target so that a bit of exception handling can be better reused
> > at the end of this function implementation.
> > 
> > Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> 
> Reviewed-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

These patches make the code worse.  If we're in the middle of a loop,
then we should clean up the partial loop before doing the goto.
Otherwise it creates a mess when we add a new allocation function after
the end of the loop.

Someone is going to add a _scoped() loop which uses cleanup.h magic to
call _put automatically.  This is a good option.

regards,
dan carpenter