| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 Mar 2024 18:02:27 +0800
From: kernel test robot <lkp@...el.com>
To: Rob Herring <robh@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: drivers/usb/host/uhci-grlib.c:92:36: error: invalid use of undefined
type 'struct platform_device'
Hi Rob,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 5ad3cb0ed525b80c7f66c32b49a68c1f3510bec9
commit: ef175b29a242fea98f467f008237484b03c94834 of: Stop circularly including of_device.h and of_platform.h
date: 6 weeks ago
config: sparc-randconfig-001-20240302 (https://download.01.org/0day-ci/archive/20240302/202403021752.PfeD05eu-lkp@intel.com/config)
compiler: sparc-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240302/202403021752.PfeD05eu-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202403021752.PfeD05eu-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from drivers/usb/host/uhci-hcd.c:850:
drivers/usb/host/uhci-grlib.c: In function 'uhci_hcd_grlib_probe':
>> drivers/usb/host/uhci-grlib.c:92:36: error: invalid use of undefined type 'struct platform_device'
92 | struct device_node *dn = op->dev.of_node;
| ^~
In file included from include/linux/printk.h:564,
from include/asm-generic/bug.h:22,
from arch/sparc/include/asm/bug.h:25,
from include/linux/bug.h:5,
from include/linux/thread_info.h:13,
from include/asm-generic/preempt.h:5,
from ./arch/sparc/include/generated/asm/preempt.h:1,
from include/linux/preempt.h:79,
from include/linux/spinlock.h:56,
from include/linux/mmzone.h:8,
from include/linux/gfp.h:7,
from include/linux/umh.h:4,
from include/linux/kmod.h:9,
from include/linux/module.h:17,
from drivers/usb/host/uhci-hcd.c:26:
drivers/usb/host/uhci-grlib.c:102:20: error: invalid use of undefined type 'struct platform_device'
102 | dev_dbg(&op->dev, "initializing GRUSBHC UHCI USB Controller\n");
| ^~
include/linux/dynamic_debug.h:224:29: note: in definition of macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:9: note: in expansion of macro '_dynamic_func_call_cls'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:273:9: note: in expansion of macro '_dynamic_func_call'
273 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/usb/host/uhci-grlib.c:102:9: note: in expansion of macro 'dev_dbg'
102 | dev_dbg(&op->dev, "initializing GRUSBHC UHCI USB Controller\n");
| ^~~~~~~
drivers/usb/host/uhci-grlib.c:109:11: error: invalid use of undefined type 'struct platform_device'
109 | op->dev.dma_mask = &op->dev.coherent_dma_mask;
| ^~
drivers/usb/host/uhci-grlib.c:109:31: error: invalid use of undefined type 'struct platform_device'
109 | op->dev.dma_mask = &op->dev.coherent_dma_mask;
| ^~
drivers/usb/host/uhci-grlib.c:110:56: error: invalid use of undefined type 'struct platform_device'
110 | hcd = usb_create_hcd(&uhci_grlib_hc_driver, &op->dev,
| ^~
drivers/usb/host/uhci-grlib.c:125:46: error: invalid use of undefined type 'struct platform_device'
125 | hcd->regs = devm_ioremap_resource(&op->dev, &res);
| ^~
drivers/usb/host/uhci-grlib.c: In function 'uhci_hcd_grlib_remove':
>> drivers/usb/host/uhci-grlib.c:152:31: error: implicit declaration of function 'platform_get_drvdata'; did you mean 'pci_get_drvdata'? [-Werror=implicit-function-declaration]
152 | struct usb_hcd *hcd = platform_get_drvdata(op);
| ^~~~~~~~~~~~~~~~~~~~
| pci_get_drvdata
drivers/usb/host/uhci-grlib.c:152:31: warning: initialization of 'struct usb_hcd *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
drivers/usb/host/uhci-grlib.c:154:20: error: invalid use of undefined type 'struct platform_device'
154 | dev_dbg(&op->dev, "stopping GRLIB GRUSBHC UHCI USB Controller\n");
| ^~
include/linux/dynamic_debug.h:224:29: note: in definition of macro '__dynamic_func_call_cls'
224 | func(&id, ##__VA_ARGS__); \
| ^~~~~~~~~~~
include/linux/dynamic_debug.h:250:9: note: in expansion of macro '_dynamic_func_call_cls'
250 | _dynamic_func_call_cls(_DPRINTK_CLASS_DFLT, fmt, func, ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~~~~~~~~
include/linux/dynamic_debug.h:273:9: note: in expansion of macro '_dynamic_func_call'
273 | _dynamic_func_call(fmt, __dynamic_dev_dbg, \
| ^~~~~~~~~~~~~~~~~~
include/linux/dev_printk.h:155:9: note: in expansion of macro 'dynamic_dev_dbg'
155 | dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~~~~~~~~~~~~~
drivers/usb/host/uhci-grlib.c:154:9: note: in expansion of macro 'dev_dbg'
154 | dev_dbg(&op->dev, "stopping GRLIB GRUSBHC UHCI USB Controller\n");
| ^~~~~~~
drivers/usb/host/uhci-grlib.c: In function 'uhci_hcd_grlib_shutdown':
drivers/usb/host/uhci-grlib.c:171:31: warning: initialization of 'struct usb_hcd *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
171 | struct usb_hcd *hcd = platform_get_drvdata(op);
| ^~~~~~~~~~~~~~~~~~~~
drivers/usb/host/uhci-grlib.c: At top level:
>> drivers/usb/host/uhci-grlib.c:184:15: error: variable 'uhci_grlib_driver' has initializer but incomplete type
184 | static struct platform_driver uhci_grlib_driver = {
| ^~~~~~~~~~~~~~~
>> drivers/usb/host/uhci-grlib.c:185:10: error: 'struct platform_driver' has no member named 'probe'
185 | .probe = uhci_hcd_grlib_probe,
| ^~~~~
drivers/usb/host/uhci-grlib.c:185:27: warning: excess elements in struct initializer
185 | .probe = uhci_hcd_grlib_probe,
| ^~~~~~~~~~~~~~~~~~~~
drivers/usb/host/uhci-grlib.c:185:27: note: (near initialization for 'uhci_grlib_driver')
>> drivers/usb/host/uhci-grlib.c:186:10: error: 'struct platform_driver' has no member named 'remove_new'
186 | .remove_new = uhci_hcd_grlib_remove,
| ^~~~~~~~~~
drivers/usb/host/uhci-grlib.c:186:27: warning: excess elements in struct initializer
186 | .remove_new = uhci_hcd_grlib_remove,
| ^~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/uhci-grlib.c:186:27: note: (near initialization for 'uhci_grlib_driver')
>> drivers/usb/host/uhci-grlib.c:187:10: error: 'struct platform_driver' has no member named 'shutdown'
187 | .shutdown = uhci_hcd_grlib_shutdown,
| ^~~~~~~~
drivers/usb/host/uhci-grlib.c:187:27: warning: excess elements in struct initializer
187 | .shutdown = uhci_hcd_grlib_shutdown,
| ^~~~~~~~~~~~~~~~~~~~~~~
drivers/usb/host/uhci-grlib.c:187:27: note: (near initialization for 'uhci_grlib_driver')
>> drivers/usb/host/uhci-grlib.c:188:10: error: 'struct platform_driver' has no member named 'driver'
188 | .driver = {
| ^~~~~~
>> drivers/usb/host/uhci-grlib.c:188:19: error: extra brace group at end of initializer
188 | .driver = {
| ^
drivers/usb/host/uhci-grlib.c:188:19: note: (near initialization for 'uhci_grlib_driver')
drivers/usb/host/uhci-grlib.c:188:19: warning: excess elements in struct initializer
drivers/usb/host/uhci-grlib.c:188:19: note: (near initialization for 'uhci_grlib_driver')
drivers/usb/host/uhci-hcd.c: In function 'uhci_hcd_init':
>> drivers/usb/host/uhci-hcd.c:885:18: error: implicit declaration of function 'platform_driver_register' [-Werror=implicit-function-declaration]
885 | retval = platform_driver_register(&PLATFORM_DRIVER);
| ^~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/usb/host/uhci-hcd.c:902:9: error: implicit declaration of function 'platform_driver_unregister'; did you mean 'driver_unregister'? [-Werror=implicit-function-declaration]
902 | platform_driver_unregister(&PLATFORM_DRIVER);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
| driver_unregister
drivers/usb/host/uhci-grlib.c: At top level:
>> drivers/usb/host/uhci-grlib.c:184:31: error: storage size of 'uhci_grlib_driver' isn't known
184 | static struct platform_driver uhci_grlib_driver = {
| ^~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +92 drivers/usb/host/uhci-grlib.c
3db7739c80990e Jan Andersson 2011-05-06 88
3db7739c80990e Jan Andersson 2011-05-06 89
41ac7b3ab7fe1d Bill Pemberton 2012-11-19 90 static int uhci_hcd_grlib_probe(struct platform_device *op)
3db7739c80990e Jan Andersson 2011-05-06 91 {
3db7739c80990e Jan Andersson 2011-05-06 @92 struct device_node *dn = op->dev.of_node;
3db7739c80990e Jan Andersson 2011-05-06 93 struct usb_hcd *hcd;
3db7739c80990e Jan Andersson 2011-05-06 94 struct uhci_hcd *uhci = NULL;
3db7739c80990e Jan Andersson 2011-05-06 95 struct resource res;
3db7739c80990e Jan Andersson 2011-05-06 96 int irq;
3db7739c80990e Jan Andersson 2011-05-06 97 int rv;
3db7739c80990e Jan Andersson 2011-05-06 98
3db7739c80990e Jan Andersson 2011-05-06 99 if (usb_disabled())
3db7739c80990e Jan Andersson 2011-05-06 100 return -ENODEV;
3db7739c80990e Jan Andersson 2011-05-06 101
3db7739c80990e Jan Andersson 2011-05-06 102 dev_dbg(&op->dev, "initializing GRUSBHC UHCI USB Controller\n");
3db7739c80990e Jan Andersson 2011-05-06 103
3db7739c80990e Jan Andersson 2011-05-06 104 rv = of_address_to_resource(dn, 0, &res);
3db7739c80990e Jan Andersson 2011-05-06 105 if (rv)
3db7739c80990e Jan Andersson 2011-05-06 106 return rv;
3db7739c80990e Jan Andersson 2011-05-06 107
3db7739c80990e Jan Andersson 2011-05-06 108 /* usb_create_hcd requires dma_mask != NULL */
3db7739c80990e Jan Andersson 2011-05-06 109 op->dev.dma_mask = &op->dev.coherent_dma_mask;
3db7739c80990e Jan Andersson 2011-05-06 110 hcd = usb_create_hcd(&uhci_grlib_hc_driver, &op->dev,
3db7739c80990e Jan Andersson 2011-05-06 111 "GRUSBHC UHCI USB");
3db7739c80990e Jan Andersson 2011-05-06 112 if (!hcd)
3db7739c80990e Jan Andersson 2011-05-06 113 return -ENOMEM;
3db7739c80990e Jan Andersson 2011-05-06 114
3db7739c80990e Jan Andersson 2011-05-06 115 hcd->rsrc_start = res.start;
28f65c11f2ffb3 Joe Perches 2011-06-09 116 hcd->rsrc_len = resource_size(&res);
3db7739c80990e Jan Andersson 2011-05-06 117
3db7739c80990e Jan Andersson 2011-05-06 118 irq = irq_of_parse_and_map(dn, 0);
8836402d4b208b Christophe Leroy 2022-11-10 119 if (!irq) {
3db7739c80990e Jan Andersson 2011-05-06 120 printk(KERN_ERR "%s: irq_of_parse_and_map failed\n", __FILE__);
3db7739c80990e Jan Andersson 2011-05-06 121 rv = -EBUSY;
ddd94257410fa6 Himangi Saraogi 2014-06-12 122 goto err_usb;
3db7739c80990e Jan Andersson 2011-05-06 123 }
3db7739c80990e Jan Andersson 2011-05-06 124
ddd94257410fa6 Himangi Saraogi 2014-06-12 125 hcd->regs = devm_ioremap_resource(&op->dev, &res);
ddd94257410fa6 Himangi Saraogi 2014-06-12 126 if (IS_ERR(hcd->regs)) {
ddd94257410fa6 Himangi Saraogi 2014-06-12 127 rv = PTR_ERR(hcd->regs);
ddd94257410fa6 Himangi Saraogi 2014-06-12 128 goto err_irq;
3db7739c80990e Jan Andersson 2011-05-06 129 }
3db7739c80990e Jan Andersson 2011-05-06 130
3db7739c80990e Jan Andersson 2011-05-06 131 uhci = hcd_to_uhci(hcd);
3db7739c80990e Jan Andersson 2011-05-06 132
3db7739c80990e Jan Andersson 2011-05-06 133 uhci->regs = hcd->regs;
3db7739c80990e Jan Andersson 2011-05-06 134
3db7739c80990e Jan Andersson 2011-05-06 135 rv = usb_add_hcd(hcd, irq, 0);
3db7739c80990e Jan Andersson 2011-05-06 136 if (rv)
ddd94257410fa6 Himangi Saraogi 2014-06-12 137 goto err_irq;
3db7739c80990e Jan Andersson 2011-05-06 138
3c9740a117d40a Peter Chen 2013-11-05 139 device_wakeup_enable(hcd->self.controller);
3db7739c80990e Jan Andersson 2011-05-06 140 return 0;
3db7739c80990e Jan Andersson 2011-05-06 141
3db7739c80990e Jan Andersson 2011-05-06 142 err_irq:
ddd94257410fa6 Himangi Saraogi 2014-06-12 143 irq_dispose_mapping(irq);
ddd94257410fa6 Himangi Saraogi 2014-06-12 144 err_usb:
3db7739c80990e Jan Andersson 2011-05-06 145 usb_put_hcd(hcd);
3db7739c80990e Jan Andersson 2011-05-06 146
3db7739c80990e Jan Andersson 2011-05-06 147 return rv;
3db7739c80990e Jan Andersson 2011-05-06 148 }
3db7739c80990e Jan Andersson 2011-05-06 149
18cb7c4d53d061 Uwe Kleine-König 2023-05-18 150 static void uhci_hcd_grlib_remove(struct platform_device *op)
3db7739c80990e Jan Andersson 2011-05-06 151 {
477527baf6a8d4 Jingoo Han 2013-05-23 @152 struct usb_hcd *hcd = platform_get_drvdata(op);
3db7739c80990e Jan Andersson 2011-05-06 153
3db7739c80990e Jan Andersson 2011-05-06 154 dev_dbg(&op->dev, "stopping GRLIB GRUSBHC UHCI USB Controller\n");
3db7739c80990e Jan Andersson 2011-05-06 155
3db7739c80990e Jan Andersson 2011-05-06 156 usb_remove_hcd(hcd);
3db7739c80990e Jan Andersson 2011-05-06 157
3db7739c80990e Jan Andersson 2011-05-06 158 irq_dispose_mapping(hcd->irq);
3db7739c80990e Jan Andersson 2011-05-06 159 usb_put_hcd(hcd);
3db7739c80990e Jan Andersson 2011-05-06 160 }
3db7739c80990e Jan Andersson 2011-05-06 161
3db7739c80990e Jan Andersson 2011-05-06 162 /* Make sure the controller is quiescent and that we're not using it
3db7739c80990e Jan Andersson 2011-05-06 163 * any more. This is mainly for the benefit of programs which, like kexec,
3db7739c80990e Jan Andersson 2011-05-06 164 * expect the hardware to be idle: not doing DMA or generating IRQs.
3db7739c80990e Jan Andersson 2011-05-06 165 *
3db7739c80990e Jan Andersson 2011-05-06 166 * This routine may be called in a damaged or failing kernel. Hence we
3db7739c80990e Jan Andersson 2011-05-06 167 * do not acquire the spinlock before shutting down the controller.
3db7739c80990e Jan Andersson 2011-05-06 168 */
3db7739c80990e Jan Andersson 2011-05-06 169 static void uhci_hcd_grlib_shutdown(struct platform_device *op)
3db7739c80990e Jan Andersson 2011-05-06 170 {
477527baf6a8d4 Jingoo Han 2013-05-23 171 struct usb_hcd *hcd = platform_get_drvdata(op);
3db7739c80990e Jan Andersson 2011-05-06 172
3db7739c80990e Jan Andersson 2011-05-06 173 uhci_hc_died(hcd_to_uhci(hcd));
3db7739c80990e Jan Andersson 2011-05-06 174 }
3db7739c80990e Jan Andersson 2011-05-06 175
3db7739c80990e Jan Andersson 2011-05-06 176 static const struct of_device_id uhci_hcd_grlib_of_match[] = {
3db7739c80990e Jan Andersson 2011-05-06 177 { .name = "GAISLER_UHCI", },
3db7739c80990e Jan Andersson 2011-05-06 178 { .name = "01_027", },
3db7739c80990e Jan Andersson 2011-05-06 179 {},
3db7739c80990e Jan Andersson 2011-05-06 180 };
3db7739c80990e Jan Andersson 2011-05-06 181 MODULE_DEVICE_TABLE(of, uhci_hcd_grlib_of_match);
3db7739c80990e Jan Andersson 2011-05-06 182
3db7739c80990e Jan Andersson 2011-05-06 183
3db7739c80990e Jan Andersson 2011-05-06 @184 static struct platform_driver uhci_grlib_driver = {
3db7739c80990e Jan Andersson 2011-05-06 @185 .probe = uhci_hcd_grlib_probe,
18cb7c4d53d061 Uwe Kleine-König 2023-05-18 @186 .remove_new = uhci_hcd_grlib_remove,
3db7739c80990e Jan Andersson 2011-05-06 @187 .shutdown = uhci_hcd_grlib_shutdown,
3db7739c80990e Jan Andersson 2011-05-06 @188 .driver = {
:::::: The code at line 92 was first introduced by commit
:::::: 3db7739c80990ef53621f76f6095a91e70d88546 USB: UHCI: Add support for GRLIB GRUSBHC controller
:::::: TO: Jan Andersson <jan@...sler.com>
:::::: CC: Greg Kroah-Hartman <gregkh@...e.de>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists