linux-kernel - Re: [PATCH -next 0/9] dm-raid, md/raid: fix v6.7 regressions part2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeNMM5mt5Tgpg3MP@redhat.com>
Date: Sat, 2 Mar 2024 10:56:35 -0500
From: Mike Snitzer <snitzer@...nel.org>
To: Song Liu <song@...nel.org>
Cc: Yu Kuai <yukuai1@...weicloud.com>, Jens Axboe <axboe@...nel.dk>,
	zkabelac@...hat.com, xni@...hat.com, agk@...hat.com,
	mpatocka@...hat.com, dm-devel@...ts.linux.dev, yukuai3@...wei.com,
	heinzm@...hat.com, neilb@...e.de, jbrassow@...hat.com,
	linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
	yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH -next 0/9] dm-raid, md/raid: fix v6.7 regressions part2

On Fri, Mar 01 2024 at  5:36P -0500,
Song Liu <song@...nel.org> wrote:

> On Fri, Mar 1, 2024 at 2:03 AM Yu Kuai <yukuai1@...weicloud.com> wrote:
> >
> > From: Yu Kuai <yukuai3@...wei.com>
> >
> > link to part1: https://lore.kernel.org/all/CAPhsuW7u1UKHCDOBDhD7DzOVtkGemDz_QnJ4DUq_kSN-Q3G66Q@mail.gmail.com/
> >
> > part1 contains fixes for deadlocks for stopping sync_thread
> >
> > This set contains fixes:
> >  - reshape can start unexpected, cause data corruption, patch 1,5,6;
> >  - deadlocks that reshape concurrent with IO, patch 8;
> >  - a lockdep warning, patch 9;
> >
> > I'm runing lvm2 tests with following scripts with a few rounds now,
> >
> > for t in `ls test/shell`; do
> >         if cat test/shell/$t | grep raid &> /dev/null; then
> >                 make check T=shell/$t
> >         fi
> > done
> >
> > There are no deadlock and no fs corrupt now, however, there are still four
> > failed tests:
> >
> > ###       failed: [ndev-vanilla] shell/lvchange-raid1-writemostly.sh
> > ###       failed: [ndev-vanilla] shell/lvconvert-repair-raid.sh
> > ###       failed: [ndev-vanilla] shell/lvcreate-large-raid.sh
> > ###       failed: [ndev-vanilla] shell/lvextend-raid.sh
> >
> > And failed reasons are the same:
> >
> > ## ERROR: The test started dmeventd (147856) unexpectedly
> >
> > I have no clue yet, and it seems other folks doesn't have this issue.
> >
> > Yu Kuai (9):
> >   md: don't clear MD_RECOVERY_FROZEN for new dm-raid until resume
> >   md: export helpers to stop sync_thread
> >   md: export helper md_is_rdwr()
> >   md: add a new helper reshape_interrupted()
> >   dm-raid: really frozen sync_thread during suspend
> >   md/dm-raid: don't call md_reap_sync_thread() directly
> >   dm-raid: add a new helper prepare_suspend() in md_personality
> >   dm-raid456, md/raid456: fix a deadlock for dm-raid456 while io
> >     concurrent with reshape
> >   dm-raid: fix lockdep waring in "pers->hot_add_disk"
> 
> This set looks good to me and passes the tests: reshape tests from
> lvm2, mdadm tests, and the reboot test that catches some issue in
> Xiao's version.
> 
> DM folks, please help review and test this set. If it looks good, we
> can route it either via the md tree (I am thinking about md-6.8
> branch) or the dm tree.

Please send these changes through md-6.8.

There are a few typos in patch subjects and headers but:

Acked-by: Mike Snitzer <snitzer@...nel.org>

> CC Jens,
> 
> I understand it is already late in the release cycle for 6.8 kernel.
> Please let us know your thoughts on this set. These patches fixes
> a crash when running lvm2 tests that are related to md-raid
> reshape.

Would be good to get these into 6.8, but worst case if they slip to
the 6.9 merge is they'll go to relevant stable kernels (due to
"Fixes:" tags, though not all commits have Fixes).

Mike