[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAHk-=wgyTTSw6yTaQ9-safdT8-MEpUWgFjqzHyeDrc8cZFui2g@mail.gmail.com>
Date: Sat, 2 Mar 2024 12:25:04 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Masami Hiramatsu <mhiramat@...nel.org>,
Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
Subject: Re: [GIT PULL] tracing: Prevent trace_marker being bigger than
unsigned short
On Sat, 2 Mar 2024 at 12:00, Steven Rostedt <rostedt@...dmis.org> wrote:
>
> I don't have control over the strings. Anyone can do in user space:
>
> fd = open("/sys/kernel/tracing/trace_marker", O_WRONLY);
> r = write(fd, huge_string, 10000000);
So?
Stop the stupidity.
You already limit the string.
Just limit it to a sane value. if somebody uses a 10kB trace marker,
return an error, or just truncate it to 100 bytes.
You already were willing to truncate it to 32kB. Use your brain, and
realize that 32kB is a ridiculous limit.
Why do I even need to tell you this? I'm getting really tired of
having these idiotic arguments with you.
Linus
Powered by blists - more mailing lists