linux-kernel - Re: [PATCH v3 01/10] crypto: ecdsa - Convert byte arrays with key coordinates to digits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240302213609.GB30938@wunner.de>
Date: Sat, 2 Mar 2024 22:36:09 +0100
From: Lukas Wunner <lukas@...ner.de>
To: Stefan Berger <stefanb@...ux.ibm.com>
Cc: Jarkko Sakkinen <jarkko@...nel.org>, keyrings@...r.kernel.org,
	linux-crypto@...r.kernel.org, herbert@...dor.apana.org.au,
	davem@...emloft.net, linux-kernel@...r.kernel.org,
	saulo.alessandre@....jus.br
Subject: Re: [PATCH v3 01/10] crypto: ecdsa - Convert byte arrays with key
 coordinates to digits

On Sat, Mar 02, 2024 at 04:19:49PM -0500, Stefan Berger wrote:
> On 3/2/24 09:00, Lukas Wunner wrote:
> > Maybe eliminate the for-loop as well?
> > 
> > 	unsigned int o = nbytes & 7;
> > 	u64 msd = 0;
> > 
> > 	if (o != 0) {
> > 		/* if key length is not a multiple of 64 bits (NIST P521) */
> > 		memcpy((u8 *)&msd + sizeof(msd) - o, in, o);
> > 		out[--ndigits] = be64_to_cpu(msd);
> > 		in += o;
> > 	}
> > 
> > 	ecc_swap_digits(in, out, ndigits);
> 
> Will take this for v5 with your Suggested-by:, ok?

Sure, feel free to, but better test it because I haven't. :-)

I'll look through the rest of the series tomorrow. %-)

Thanks,

Lukas