linux-kernel - RE: [PATCH v5 3/5] crypto: tegra: Add Tegra Security Engine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <SJ1PR12MB63398B52A8FB2978636FAF8DC05D2@SJ1PR12MB6339.namprd12.prod.outlook.com>
Date: Sat, 2 Mar 2024 02:44:11 +0000
From: Akhil R <akhilrajeev@...dia.com>
To: Herbert Xu <herbert@...dor.apana.org.au>
CC: "davem@...emloft.net" <davem@...emloft.net>, "robh+dt@...nel.org"
	<robh+dt@...nel.org>, "krzysztof.kozlowski+dt@...aro.org"
	<krzysztof.kozlowski+dt@...aro.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, "thierry.reding@...il.com" <thierry.reding@...il.com>,
	Jon Hunter <jonathanh@...dia.com>, "catalin.marinas@....com"
	<catalin.marinas@....com>, "will@...nel.org" <will@...nel.org>, Mikko
 Perttunen <mperttunen@...dia.com>, "linux-crypto@...r.kernel.org"
	<linux-crypto@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-tegra@...r.kernel.org"
	<linux-tegra@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "krzk@...nel.org" <krzk@...nel.org>
Subject: RE: [PATCH v5 3/5] crypto: tegra: Add Tegra Security Engine driver

> >
> > Do we have any other concerns with the driver currently, which I can
> > address in the next revision?
> 
> The sha export/import code looks good now.  Does it pass all the self-tests,
> including extra fuzzing?
> 
> The same export/import issue still exists with cmac so please fix that.
> 
I do see some warnings for some AES algorithms with extra fuzzing.
Will send a new version with the CMAC import/export update and the
extra fuzzing warning fixes.

Thanks,
Akhil