[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sun, 3 Mar 2024 13:23:46 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: linux-iio@...r.kernel.org, Michael Hennerich
<Michael.Hennerich@...log.com>, Rob Herring <robh+dt@...nel.org>, Krzysztof
Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Conor Dooley
<conor+dt@...nel.org>, Nuno Sá <nuno.sa@...log.com>, Liam
Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: iio: adc: add ad7944 ADCs
On Thu, 29 Feb 2024 10:25:50 -0600
David Lechner <dlechner@...libre.com> wrote:
> This adds a new binding for the Analog Devices, Inc. AD7944, AD7985, and
> AD7986 ADCs.
>
> Signed-off-by: David Lechner <dlechner@...libre.com>
Hi David,
One trivial comment. If this is all that comes up I can tweak that whilst applying.
Jonathan
..
> + adi,spi-mode:
> + $ref: /schemas/types.yaml#/definitions/string
> + enum: [ single, chain ]
> + description: |
> + This property indicates the SPI wiring configuration.
> +
> + When this property is omitted, it is assumed that the device is using what
> + the he datasheet calls "4-wire mode". This is the conventional SPI mode
Stray "he"?
> + used when there are multiple devices on the same bus. In this mode, the
> + CNV line is used to initiate the conversion and the SDI line is connected
> + to CS on the SPI controller.
>
Powered by blists - more mailing lists