[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sun, 3 Mar 2024 20:21:53 +0100
From: Philipp Hortmann <philipp.g.hortmann@...il.com>
To: Ariel Silver <arielsilver77@...il.com>, gregkh@...uxfoundation.org,
yogi.kernel@...il.com, dan.carpenter@...aro.org, straube.linux@...il.com,
garyrookard@...tmail.org
Cc: linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8192e: Declare variable with static
On 3/1/24 16:31, Ariel Silver wrote:
> Fixed sparse warning:
> "'dm_rx_path_sel_table' was not declared. Should it be static?"
> As dm_rx_path_sel_table is used only in rtl_dm.c it should be static.
>
> Signed-off-by: Ariel Silver <arielsilver77@...il.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index 92143c50c149..850ee6ae1f02 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> @@ -144,7 +144,7 @@ const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = {
> /*------------------------Define global variable-----------------------------*/
> struct dig_t dm_digtable;
>
> -struct drx_path_sel dm_rx_path_sel_table;
> +static struct drx_path_sel dm_rx_path_sel_table;
> /*------------------------Define global variable-----------------------------*/
>
>
Hi Ariel,
I need to tell you that you need a change history. There is also the v2
missing in the subject. Please make a v3 with change history.
Thanks
Bye Philipp
Powered by blists - more mailing lists