linux-kernel - Re: [PATCH net-next 13/21] rxrpc: Use rxrpc_txbuf::kvec[0] instead of rxrpc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240302212615.310678df@kernel.org>
Date: Sat, 2 Mar 2024 21:26:15 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: David Howells <dhowells@...hat.com>
Cc: netdev@...r.kernel.org, Marc Dionne <marc.dionne@...istor.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo
 Abeni <pabeni@...hat.com>, linux-afs@...ts.infradead.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 13/21] rxrpc: Use rxrpc_txbuf::kvec[0] instead
 of rxrpc_txbuf::wire

On Fri,  1 Mar 2024 16:37:45 +0000 David Howells wrote:
> Use rxrpc_txbuf::kvec[0] instead of rxrpc_txbuf::wire to gain access to the
> Rx protocol header.  In future, the wire header will be stored in a page
> frag, not in the rxrpc_txbuf struct making it possible to use
> MSG_SPLICE_PAGES when sending it.
> 
> Similarly, access the ack header as being immediately after the wire header
> when filling out an ACK packet.

net/rxrpc/output.c:263:28: warning: unused variable 'whdr' [-Wunused-variable]
  263 |         struct rxrpc_wire_header *whdr;
      |                                   ^~~~