linux-kernel - Re: [PATCH] Input: iqs269a - Use common error handling code in iqs269_parse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 3 Mar 2024 14:31:45 -0800
From: Dmitry Torokhov <dmitry.torokhov@...il.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-input@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Jeff LaBundy <jeff@...undy.com>,
	Mattijs Korpershoek <mkorpershoek@...libre.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	ye xingchen <ye.xingchen@....com.cn>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Input: iqs269a - Use common error handling code in
 iqs269_parse_chan()

Hi Markus,

On Sat, Mar 02, 2024 at 09:24:53AM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Sat, 2 Mar 2024 09:15:20 +0100
> 
> Add a jump target so that a bit of exception handling can be better reused
> at the end of this function implementation.

No, I do not think this is needed. However if you can introduce a fwnode
cleanup/free function (see include/linux/cleanup.h) maybe it would be
more useful and we could apply it to various drivers.

Thanks.

-- 
Dmitry