linux-kernel - Re: [PATCH] staging: vme_user: Ensure blank lines after variable declarations and fix misaligned */ comment formatting issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 3 Mar 2024 07:56:38 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Jonathan Bergh <bergh.jonathan@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH] staging: vme_user: Ensure blank lines after variable
 declarations and fix misaligned */ comment formatting issues

On Sat, Mar 02, 2024 at 11:14:54PM +0100, Jonathan Bergh wrote:
> This patch fixes the following issues:
>  * Ensures a blank line after declarations
>  * Ensures */ is aligned with its correct opening /*
> 
> Signed-off-by: Jonathan Bergh <bergh.jonathan@...il.com>
> ---
>  drivers/staging/vme_user/vme_tsi148.h | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> index 4dd224d0b86e..674d83325e42 100644
> --- a/drivers/staging/vme_user/vme_tsi148.h
> +++ b/drivers/staging/vme_user/vme_tsi148.h
> @@ -34,6 +34,7 @@ struct tsi148_driver {
>  	void __iomem *base;	/* Base Address of device registers */
>  	wait_queue_head_t dma_queue[2];
>  	wait_queue_head_t iack_queue;
> +
>  	void (*lm_callback[4])(void *);	/* Called in interrupt handler */
>  	void *lm_data[4];
>  	void *crcsr_kernel;
> @@ -691,8 +692,7 @@ static const int TSI148_GCSR_MBOX[4] = { TSI148_GCSR_MBOX0,
>  
>  #define TSI148_LCSR_VMCTRL_RMWEN       BIT(20)	/* RMW Enable */
>  
> -#define TSI148_LCSR_VMCTRL_ATO_M       (7 << 16)	/* Master Access Time-out Mask
> -						 */
> +#define TSI148_LCSR_VMCTRL_ATO_M       (7 << 16)	/* Master Access Time-out Mask*/
>  #define TSI148_LCSR_VMCTRL_ATO_32      (0 << 16)	/* 32 us */
>  #define TSI148_LCSR_VMCTRL_ATO_128     BIT(16)	/* 128 us */
>  #define TSI148_LCSR_VMCTRL_ATO_512     (2 << 16)	/* 512 us */
> @@ -753,8 +753,7 @@ static const int TSI148_GCSR_MBOX[4] = { TSI148_GCSR_MBOX0,
>  #define TSI148_LCSR_VCTRL_DLT_16384    (0xB << 24)	/* 16384 VCLKS */
>  #define TSI148_LCSR_VCTRL_DLT_32768    (0xC << 24)	/* 32768 VCLKS */
>  
> -#define TSI148_LCSR_VCTRL_NERBB        BIT(20)	/* No Early Release of Bus Busy
> -						 */
> +#define TSI148_LCSR_VCTRL_NERBB        BIT(20)	/* No Early Release of Bus Busy*/
>  
>  #define TSI148_LCSR_VCTRL_SRESET       BIT(17)	/* System Reset */
>  #define TSI148_LCSR_VCTRL_LRESET       BIT(16)	/* Local Reset */
> -- 
> 2.40.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- Your patch did many different things all at once, making it difficult
  to review.  All Linux kernel patches need to only do one thing at a
  time.  If you need to do multiple things (such as clean up all coding
  style issues in a file/driver), do it in a sequence of patches, each
  one doing only one thing.  This will make it easier to review the
  patches to ensure that they are correct, and to help alleviate any
  merge issues that larger patches can cause.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot