linux-kernel - Re: [PATCH] compiler.h: Explain how __is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKwvOdkzQCSM1+Z1mRphgu3Vs8SdiDpgxywWiO_OHn+S_Z6UwA@mail.gmail.com>
Date: Mon, 4 Mar 2024 08:52:58 -0800
From: Nick Desaulniers <ndesaulniers@...gle.com>
To: Kees Cook <keescook@...omium.org>
Cc: Rasmus Villemoes <linux@...musvillemoes.dk>, 
	"Gustavo A . R . Silva" <gustavoars@...nel.org>, Miguel Ojeda <miguel.ojeda.sandonis@...il.com>, 
	Jani Nikula <jani.nikula@...ux.intel.com>, David Laight <David.Laight@...lab.com>, 
	Martin Uecker <Martin.Uecker@....uni-goettingen.de>, Jonathan Corbet <corbet@....net>, 
	linux-doc@...r.kernel.org, Miguel Ojeda <ojeda@...nel.org>, linux-kernel@...r.kernel.org, 
	linux-hardening@...r.kernel.org
Subject: Re: [PATCH] compiler.h: Explain how __is_constexpr() works

On Thu, Feb 29, 2024 at 8:44 PM Kees Cook <keescook@...omium.org> wrote:
>
> The __is_constexpr() macro is dark magic. Shed some light on it with
> a comment to explain how and why it works.
>
> Acked-by: Gustavo A. R. Silva <gustavoars@...nel.org>
> Signed-off-by: Kees Cook <keescook@...omium.org>

Is Documentation/kernel-hacking/hacking.rst perhaps a more appropriate
place for this block of text?  Perhaps as another :c:macro: in that
file?

You know I'm not a big fan of increasing header size, even if it is
just a comment.
-- 
Thanks,
~Nick Desaulniers