linux-kernel - Re: [PATCH] drm/panel: panel-edp: Add prepare_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 4 Mar 2024 09:16:55 -0800
From: Doug Anderson <dianders@...omium.org>
To: Zhengqiao Xia <xiazhengqiao@...qin.corp-partner.google.com>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org, 
	neil.armstrong@...aro.org, quic_jesszhan@...cinc.com, sam@...nborg.org, 
	maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de, 
	airlied@...il.com, daniel@...ll.ch
Subject: Re: [PATCH] drm/panel: panel-edp: Add prepare_to_enable to 200ms for MNC207QS1-1

Hi,

On Fri, Mar 1, 2024 at 12:40 AM Zhengqiao Xia
<xiazhengqiao@...qin.corp-partner.google.com> wrote:
>
> For MNC207QS1-1 panel, Splash screen occur when switch from VT1 to VT2.
> The BL_EN signal does not conform to the VESA protocol.
> BL_EN signal needs to be pulled high after video signal.
> So add prepare_to_enable to 200ms.
>
> Signed-off-by: Zhengqiao Xia <xiazhengqiao@...qin.corp-partner.google.com>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)

Should have:

Fixes: 0547692ac146 ("drm/panel-edp: Add several generic edp panels")

Also note that the subject tag "drm/panel-edp" is much more common
than others for this file and probably better to use that than
"drm/panel: panel-edp".

Other than that this looks fine to me. Applying to drm-misc-next since
the patch this is fixing isn't in mainline yet and this doesn't seem
massively urgent.

e635b7eb7062 drm/panel-edp: Add prepare_to_enable to 200ms for MNC207QS1-1

-Doug