linux-kernel - Re: [PATCH v2] scsi: lpfc: correct size for cmdwqe/rspwqe for memset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 4 Mar 2024 10:25:43 -0800
From: Justin Tee <justin.tee@...adcom.com>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>
Cc: James Smart <james.smart@...adcom.com>, Dick Kennedy <dick.kennedy@...adcom.com>, 
	"James E.J. Bottomley" <jejb@...ux.ibm.com>, "Martin K. Petersen" <martin.petersen@...cle.com>, kernel@...labora.com, 
	kernel-janitors@...r.kernel.org, James Smart <jsmart2021@...il.com>, 
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: lpfc: correct size for cmdwqe/rspwqe for memset

> The cmdwqe and rspwqe are of type lpfc_wqe128. They should be memset
> with the same type.
>
> Fixes: 61910d6a5243 ("scsi: lpfc: SLI path split: Refactor CT paths")
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> ---
> Changes since v1:
> - Use *ptr instead of specifying type in sizeof
> ---
>  drivers/scsi/lpfc/lpfc_bsg.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
> index d80e6e81053b0..7d5275d3a7406 100644
> --- a/drivers/scsi/lpfc/lpfc_bsg.c
> +++ b/drivers/scsi/lpfc/lpfc_bsg.c
> @@ -3169,10 +3169,10 @@ lpfc_bsg_diag_loopback_run(struct bsg_job *job)
>         }
>
>         cmdwqe = &cmdiocbq->wqe;
> -       memset(cmdwqe, 0, sizeof(union lpfc_wqe));
> +       memset(cmdwqe, 0, sizeof(*cmdwqe));
>         if (phba->sli_rev < LPFC_SLI_REV4) {
>                 rspwqe = &rspiocbq->wqe;
> -               memset(rspwqe, 0, sizeof(union lpfc_wqe));
> +               memset(rspwqe, 0, sizeof(*rspwqe));
>         }
>
>         INIT_LIST_HEAD(&head);
> --
> 2.39.2
>

Reviewed-by: Justin Tee <justin.tee@...adcom.com>

-- 
This electronic communication and the information and any files transmitted 
with it, or attached to it, are confidential and are intended solely for 
the use of the individual or entity to whom it is addressed and may contain 
information that is confidential, legally privileged, protected by privacy 
laws, or otherwise restricted from disclosure to anyone else. If you are 
not the intended recipient or the person responsible for delivering the 
e-mail to the intended recipient, you are hereby notified that any use, 
copying, distributing, dissemination, forwarding, printing, or copying of 
this e-mail is strictly prohibited. If you received this e-mail in error, 
please return the e-mail to the sender, delete it from your computer, and 
destroy any printed copy of it.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4203 bytes)