linux-kernel - Re: [PATCH net] net: phy: qca807x: fix compilation when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 4 Mar 2024 20:29:21 +0100
From: Robert Marko <robimarko@...il.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: andersson@...nel.org, konrad.dybcio@...aro.org, andrew@...n.ch, 
	hkallweit1@...il.com, davem@...emloft.net, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, ansuelsmth@...il.com, 
	linux-arm-msm@...r.kernel.org, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH net] net: phy: qca807x: fix compilation when
 CONFIG_GPIOLIB is not set

On Mon, 4 Mar 2024 at 20:27, Russell King (Oracle)
<linux@...linux.org.uk> wrote:
>
> On Mon, Mar 04, 2024 at 08:21:36PM +0100, Robert Marko wrote:
> > -     if (IS_ENABLED(CONFIG_GPIOLIB)) {
> > +#if IS_ENABLED(CONFIG_GPIOLIB)
> >               /* Make sure we don't have mixed leds node and gpio-controller
> >                * to prevent registering leds and having gpio-controller usage
> >                * conflicting with them.
> > @@ -749,7 +749,7 @@ static int qca807x_probe(struct phy_device *phydev)
> >                       if (ret)
> >                               return ret;
> >               }
> > -     }
> > +#endif
>
> I know it makes for a bigger patch, but #if is not equivalent to if()
> in terms of indentation, so the indentation also needs to be changed.

Oh, sorry for that, it completely slipped my mind.
I will fix it in v2, and will send it tomorrow afternoon to give
others time to comment.

Regards,
Robert
>
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!