linux-kernel - Re: [PATCH] media: v4l2-fwnode: Improve exception handling in v4l2_fwnode_connector_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZeV25-dTLVE_vyqx@kekkonen.localdomain>
Date: Mon, 4 Mar 2024 07:23:19 +0000
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-media@...r.kernel.org, kernel-janitors@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] media: v4l2-fwnode: Improve exception handling in
 v4l2_fwnode_connector_add_link()

Hi Markus,

On Fri, Mar 01, 2024 at 03:07:50PM +0100, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Fri, 1 Mar 2024 15:02:09 +0100
> 
> The kfree() function was called in one case by
> the v4l2_fwnode_connector_add_link() function during error handling
> even if the passed variable contained a null pointer.
> Thus use another label.

This isn't a problem, the code is fine as-is.

> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/media/v4l2-core/v4l2-fwnode.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/v4l2-core/v4l2-fwnode.c b/drivers/media/v4l2-core/v4l2-fwnode.c
> index 89c7192148df..dc6daf3a9a51 100644
> --- a/drivers/media/v4l2-core/v4l2-fwnode.c
> +++ b/drivers/media/v4l2-core/v4l2-fwnode.c
> @@ -744,7 +744,7 @@ int v4l2_fwnode_connector_add_link(struct fwnode_handle *fwnode,
>  	link = kzalloc(sizeof(*link), GFP_KERNEL);
>  	if (!link) {
>  		err = -ENOMEM;
> -		goto err;
> +		goto put_fwnode_ep;
>  	}
> 
>  	err = v4l2_fwnode_parse_link(connector_ep, &link->fwnode_link);
> @@ -760,6 +760,7 @@ int v4l2_fwnode_connector_add_link(struct fwnode_handle *fwnode,
> 
>  err:
>  	kfree(link);
> +put_fwnode_ep:
>  	fwnode_handle_put(connector_ep);
> 
>  	return err;
> --
> 2.44.0
> 

-- 
Sakari Ailus