lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20240304073736.om5rptz4pzn6ydmf@pengutronix.de>
Date: Mon, 4 Mar 2024 08:37:36 +0100
From: Marco Felsch <m.felsch@...gutronix.de>
To: Rob Herring <robh@...nel.org>
Cc: frowand.list@...il.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel@...gutronix.de
Subject: Re: [PATCH] of: property: lower loglevel of
 of_graph_get_next_endpoint

On 24-03-01, Rob Herring wrote:
> On Fri, Feb 23, 2024 at 11:47:21AM +0100, Marco Felsch wrote:
> > Drivers like the tcpm.c do search for a remote endpoint on different
> > places to be dt-bindings compatible. The search is done on the device
> > itself or on the child fwnode in case it was not found the first time.
> > 
> > This indicates that not finding the remote endpoint at the first try is
> > a valid use-case and should not cause an error printing.
> > 
> > Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>
> > ---
> > Hi,
> > 
> > I'm not 100% certain if this is the correct place but if our platform
> > follows the dt-bindings we receive
> > 
> > | OF: graph: no port node found in /soc@...us@...00000/i2c@...30000/tcpc@50
> > 
> > a few times because of the below pr_err() and EPROBE_DEFER.
> > 
> > Regards,
> >   Marco
> > 
> >  drivers/of/property.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/of/property.c b/drivers/of/property.c
> > index 641a40cf5cf3..155df04a9512 100644
> > --- a/drivers/of/property.c
> > +++ b/drivers/of/property.c
> > @@ -665,7 +665,7 @@ struct device_node *of_graph_get_next_endpoint(const struct device_node *parent,
> >  		of_node_put(node);
> >  
> >  		if (!port) {
> > -			pr_err("graph: no port node found in %pOF\n", parent);
> > +			pr_notice("graph: no port node found in %pOF\n", parent);
> 
> Already changed to pr_debug.

Ah.. didn't noticed that albeit I was sitting on rc4 while preparing
this patch. Thanks for the info :)

Regards,
  Marco


> 
> Rob
> 

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ