linux-kernel - Re: linux-next: Tree for Mar 1 (riscv 32-bit)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <79b41dfc-004e-4939-b045-0c320037e584@ghiti.fr>
Date: Mon, 4 Mar 2024 09:08:32 +0100
From: Alexandre Ghiti <alex@...ti.fr>
To: Randy Dunlap <rdunlap@...radead.org>,
 Stephen Rothwell <sfr@...b.auug.org.au>,
 Linux Next Mailing List <linux-next@...r.kernel.org>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
 linux-riscv <linux-riscv@...ts.infradead.org>
Subject: Re: linux-next: Tree for Mar 1 (riscv 32-bit)

Hi Randy,

On 02/03/2024 06:37, Randy Dunlap wrote:
>
> On 2/29/24 21:57, Stephen Rothwell wrote:
>> Hi all,
>>
>> Changes since 20240229:
>>
> on riscv 32-bit:
>
> In file included from ../arch/riscv/include/asm/uaccess.h:12,
>                   from ../include/linux/uaccess.h:11,
>                   from ../include/linux/sched/task.h:13,
>                   from ../include/linux/sched/signal.h:9,
>                   from ../include/linux/rcuwait.h:6,
>                   from ../include/linux/percpu-rwsem.h:7,
>                   from ../include/linux/fs.h:33,
>                   from ../kernel/events/core.c:11:
> ../kernel/events/core.c: In function 'perf_get_pgtable_size':
> ../arch/riscv/include/asm/pgtable.h:443:41: error: implicit declaration of function 'napot_cont_size' [-Werror=implicit-function-declaration]
>    443 |                                         napot_cont_size(napot_cont_order(pte)) :\
>        |                                         ^~~~~~~~~~~~~~~
> ../kernel/events/core.c:7588:24: note: in expansion of macro 'pte_leaf_size'
>   7588 |                 size = pte_leaf_size(pte);
>        |                        ^~~~~~~~~~~~~
> ../arch/riscv/include/asm/pgtable.h:443:57: error: implicit declaration of function 'napot_cont_order'; did you mean 'get_count_order'? [-Werror=implicit-function-declaration]
>    443 |                                         napot_cont_size(napot_cont_order(pte)) :\
>        |                                                         ^~~~~~~~~~~~~~~~
> ../kernel/events/core.c:7588:24: note: in expansion of macro 'pte_leaf_size'
>   7588 |                 size = pte_leaf_size(pte);
>        |                        ^~~~~~~~~~~~~
>
>
> Full randconfig file is attached.
>

I missed it because this patch interacts with FAST_GUP support merged in 
for-next. But what this means is that the fix I sent for 6.8-rc7 was not 
needed at all...my bad, sorry.

I have just sent a fix here: 
https://lore.kernel.org/linux-riscv/20240304080247.387710-1-alexghiti@rivosinc.com/T/#u

Thanks,

Alex