linux-kernel - Re: [PATCH v3 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4d09ccba-32f6-453d-a4aa-6c5b127a1721@oracle.com>
Date: Mon, 4 Mar 2024 08:18:09 +0000
From: John Garry <john.g.garry@...cle.com>
To: Igor Pylypiv <ipylypiv@...gle.com>, Damien Le Moal <dlemoal@...nel.org>,
        Niklas Cassel <cassel@...nel.org>, Jason Yan <yanaijie@...wei.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Jack Wang <jinpu.wang@...ud.ionos.com>, Hannes Reinecke <hare@...e.de>,
        Xiang Chen <chenxiang66@...ilicon.com>,
        Artur Paszkiewicz <artur.paszkiewicz@...el.com>,
        Bart Van Assche <bvanassche@....org>
Cc: TJ Adams <tadamsjr@...gle.com>, linux-ide@...r.kernel.org,
        linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/7] scsi: hisi_sas: Add libsas SATA sysfs attributes
 group

On 02/03/2024 20:16, Igor Pylypiv wrote:
> The added sysfs attributes group enables the configuration of NCQ Priority
> feature for HBAs that rely on libsas to manage SATA devices.
> 
> Signed-off-by: Igor Pylypiv<ipylypiv@...gle.com>

Apart from comment on v1 HW:
Reviewed-by: John Garry <john.g.garry@...cle.com>

> ---
>   drivers/scsi/hisi_sas/hisi_sas_v1_hw.c | 6 ++++++
>   drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 6 ++++++
>   drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 6 ++++++
>   3 files changed, 18 insertions(+)
> 
> diff --git a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> index 3c555579f9a1..97864b56a71f 100644
> --- a/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> +++ b/drivers/scsi/hisi_sas/hisi_sas_v1_hw.c
> @@ -1734,6 +1734,11 @@ static struct attribute *host_v1_hw_attrs[] = {
>   
>   ATTRIBUTE_GROUPS(host_v1_hw);
>   
> +static const struct attribute_group *sdev_groups_v1_hw[] = {
> +	&sas_ata_sdev_attr_group,

IIRC, this driver never supported SATA

> +	NULL
> +};
> +
>   static const struct scsi_host_template sht_v1_hw = {
>   	.name			= DRV_NAME,
>   	.proc_name		= DRV_NAME,
> @@ -1758,6 +1763,7 @@ static const struct scsi_host_template sht_v1_hw = {
>   	.compat_ioctl		= sas_ioctl,
>   #endif
>   	.shost_groups		= host_v1_hw_groups,
> +	.sdev_groups		= sdev_groups_v1_hw,
>   	.host_reset             = hisi_sas_host_reset,
>   };