linux-kernel - Re: [PATCH 2/4] arm64: dts: mediatek: mt7622: fix IR nodename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33145efb-b13c-4a1c-9542-9a185fca7b01@collabora.com>
Date: Mon, 4 Mar 2024 11:12:38 +0100
From: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
To: Rafał Miłecki <zajec5@...il.com>,
 Matthias Brugger <matthias.bgg@...il.com>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
 Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH 2/4] arm64: dts: mediatek: mt7622: fix IR nodename

Il 01/03/24 12:35, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <rafal@...ecki.pl>
> 
> Fix following validation error:
> arch/arm64/boot/dts/mediatek/mt7622-rfb1.dtb: cir@...09000: $nodename:0: 'cir@...09000' does not match '^ir(-receiver)?(@[a-f0-9]+)?$'
>          from schema $id: http://devicetree.org/schemas/media/mediatek,mt7622-cir.yaml#
> 
> Signed-off-by: Rafał Miłecki <rafal@...ecki.pl>

Is this an IR receiver, an IR transmitter or a xceiver?

While we're fixing that node name, we might as well increase readability of (and
somewhat implicitly document) this.

.. so, that might be...:

ir-receiver@...xx {
...

Cheers,
Angelo

> ---
>   arch/arm64/boot/dts/mediatek/mt7622.dtsi | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> index 283fdf7d2d8b..7714775d1bd0 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi
> @@ -252,7 +252,7 @@ scpsys: power-controller@...06000 {
>   		clock-names = "hif_sel";
>   	};
>   
> -	cir: cir@...09000 {
> +	cir: ir@...09000 {
>   		compatible = "mediatek,mt7622-cir";
>   		reg = <0 0x10009000 0 0x1000>;
>   		interrupts = <GIC_SPI 175 IRQ_TYPE_LEVEL_LOW>;