linux-kernel - Re: [PATCH] fbdev/chipsfb: Include <linux/backlight.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878r2y5jsl.fsf@intel.com>
Date: Mon, 04 Mar 2024 13:16:26 +0200
From: Jani Nikula <jani.nikula@...el.com>
To: Thomas Zimmermann <tzimmermann@...e.de>, mpe@...erman.id.au,
 naresh.kamboju@...aro.org, deller@....de
Cc: dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
 lkft-triage@...ts.linaro.org, linux-kernel@...r.kernel.org, Thomas
 Zimmermann <tzimmermann@...e.de>
Subject: Re: [PATCH] fbdev/chipsfb: Include <linux/backlight.h>

On Mon, 04 Mar 2024, Thomas Zimmermann <tzimmermann@...e.de> wrote:
> Fix builds with CONFIG_PMAC_BACKLIGHT=y. The include statement for
> the backlight header has recently been removed from <linux/fb.h>.
>
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Closes: https://lore.kernel.org/dri-devel/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com/
> Signed-off-by: Thomas Zimmermann <tzimmermann@...e.de>
> Fixes: 11b4eedfc87d ("fbdev: Do not include <linux/backlight.h> in header")
> Cc: Thomas Zimmermann <tzimmermann@...e.de>
> Cc: Jani Nikula <jani.nikula@...el.com>
> Cc: Helge Deller <deller@....de>
> Cc: linux-fbdev@...r.kernel.org
> Cc: dri-devel@...ts.freedesktop.org

I would've added the include in arch/powerpc/include/asm/backlight.h
[1], but either way is fine by me.

Reviewed-by: Jani Nikula <jani.nikula@...el.com>


[1] https://lore.kernel.org/r/20240304095512.742348-1-jani.nikula@intel.com

> ---
>  drivers/video/fbdev/chipsfb.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/chipsfb.c b/drivers/video/fbdev/chipsfb.c
> index b80711f13df8a..b16a905588fed 100644
> --- a/drivers/video/fbdev/chipsfb.c
> +++ b/drivers/video/fbdev/chipsfb.c
> @@ -15,6 +15,7 @@
>   */
>  
>  #include <linux/aperture.h>
> +#include <linux/backlight.h>
>  #include <linux/module.h>
>  #include <linux/kernel.h>
>  #include <linux/errno.h>

-- 
Jani Nikula, Intel