linux-kernel - Re: [PATCH 1/4] iio: pressure: BMP280 core driver headers sorting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZeWyKhIEm8D13C__@smile.fi.intel.com>
Date: Mon, 4 Mar 2024 13:36:10 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Vasileios Amoiridis <vassilisamir@...il.com>
Cc: jic23@...nel.org, lars@...afoo.de, ang.iglesiasg@...il.com,
	mazziesaccount@...il.com, ak@...klinger.de,
	petre.rodan@...dimension.ro, phil@...pberrypi.com, 579lpy@...il.com,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] iio: pressure: BMP280 core driver headers sorting

On Sun, Mar 03, 2024 at 05:52:57PM +0100, Vasileios Amoiridis wrote:
> Sort headers in alphabetical order.

..

>  #include <linux/bitops.h>
>  #include <linux/bitfield.h>
> -#include <linux/device.h>
> -#include <linux/module.h>
> -#include <linux/nvmem-provider.h>
> -#include <linux/regmap.h>
> +#include <linux/completion.h>
>  #include <linux/delay.h>
> +#include <linux/device.h>
> +#include <linux/gpio/consumer.h>

>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>

(see below)

> -#include <linux/gpio/consumer.h>
> -#include <linux/regulator/consumer.h>
>  #include <linux/interrupt.h>
>  #include <linux/irq.h> /* For irq_get_irq_data() */
> -#include <linux/completion.h>
> +#include <linux/module.h>
> +#include <linux/nvmem-provider.h>
>  #include <linux/pm_runtime.h>
>  #include <linux/random.h>
> +#include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>

While at it, please, move iio/* group to be here (and surrounded by
blank lines).

>  #include <asm/unaligned.h>

-- 
With Best Regards,
Andy Shevchenko