linux-kernel - Re: [PATCH v1 1/1] clk: fractional-divider: Use bit operations consistently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXv+5H-xLEO8A2=BbYEOzZyX9x+-0tnkV-s60x6iYTjntGw_g@mail.gmail.com>
Date: Mon, 4 Mar 2024 11:24:35 +0800
From: Chen-Yu Tsai <wenst@...omium.org>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Michael Turquette <mturquette@...libre.com>, Stephen Boyd <sboyd@...nel.org>
Subject: Re: [PATCH v1 1/1] clk: fractional-divider: Use bit operations consistently

On Sun, Mar 3, 2024 at 8:07 PM Andy Shevchenko
<andy.shevchenko@...il.com> wrote:
>
> Use BIT() where makes sense. This alings usage of bit operations
> in the same pieces of code. Moreover, strictly speaking by the
> letter of the C standard, left shift of 1 by 31 bits is UB (undefined
> behaviour), switching to BIT() addresses that as well.
>
> Signed-off-by: Andy Shevchenko <andy.shevchenko@...il.com>

Reviewed-by: Chen-Yu Tsai <wenst@...omium.org>