linux-kernel - Re: [PATCH net v2] netfilter: Add protection for bmp length out of range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 4 Mar 2024 13:41:19 +0100
From: Pablo Neira Ayuso <pablo@...filter.org>
To: Florian Westphal <fw@...len.de>
Cc: Lena Wang (王娜) <Lena.Wang@...iatek.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"kadlec@...filter.org" <kadlec@...filter.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"netfilter-devel@...r.kernel.org" <netfilter-devel@...r.kernel.org>
Subject: Re: [PATCH net v2] netfilter: Add protection for bmp length out of
 range

On Sat, Mar 02, 2024 at 12:52:41PM +0100, Florian Westphal wrote:
> Pablo Neira Ayuso <pablo@...filter.org> wrote:
> > > +	if (f->sz > 32)
> > > +		return H323_ERROR_RANGE;
> > 
> > Could you possibly place this in get_bitmap()? IIRC these are the only
> > two calls to this function.
> 
> How would you signal the error?  I think this patch is fine as-is.

Provide the bitmap instead as parameter, but this opencode variant
also LGTM, I am probably overdoing, we can take this as is.

Thanks.