linux-kernel - Re: [PATCH V2 4/9] platform/x86/intel/sdsi: Add attribute to read the current meter state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e9fe5a5-4270-a71d-bb36-4f7d0a1ca049@linux.intel.com>
Date: Mon, 4 Mar 2024 15:29:39 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: "David E. Box" <david.e.box@...ux.intel.com>
cc: rajvi.jingar@...ux.intel.com, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>, Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH V2 4/9] platform/x86/intel/sdsi: Add attribute to read
 the current meter state

On Tue, 27 Feb 2024, David E. Box wrote:

> The meter_certificate file provides access to metering information that may
> be attested but is only updated every 8 hours. Add new attribute,
> meter_current, to allow reading an untested snapshot of the current values.
> 
> Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
> ---
> 
> V2 - make control_flags a parameter to be eventually passed to
>      sdsi_mbox_cmd_read(). This removes the need for a lock which had been
>      added to protect control_flags when it was a member of the private
>      struct.

Yes, thanks. It's more obvious now what's going on w/o all that lock 
trickery.

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

-- 
 i.